Switch to go-kit logging #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasr
reviewed
Oct 10, 2019
Fixes prometheus#270 Signed-off-by: mhartenbower <matt.hartenbower@gmail.com>
mhartenbower
force-pushed
the
master
branch
2 times, most recently
from
121af1d to
65512ed
Compare
Signed-off-by: mhartenbower <matt.hartenbower@gmail.com>
|
@matthiasr I'm not actually sure what the problem is at this point. The build looks good. It's failing on Mind taking a look? |
|
It looks like it thinks that the vendor directory and go modules are out of sync. Could you
and commit the changes that the last two commands make? You can also try running |
|
Did you have a chance to look at the vendoring issues? |
|
@brian-brazil Will get it resolved this weekend. |
|
Did you get anywhere with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #270