Added support for sampling factor on timing events #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We apparently missed this pull request. @yoshiyaka Can you rebase against current master and adjust? |
|
@yoshiyaka Are you still maintaining this PR ? |
|
Yes, but there are quite a few merge conflicts that I don't have the time to solve right now. Should I close this and open a new PR once they've been fixed? |
|
@yoshiyaka Ping, do you want to fix this up and get it merged? |
|
Now it should be ready to go. Sorry for the delay :) |
|
Thanks! We should refactor and clean up the statsd exporter at some point, but that's outside of the scope of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for sampling rate in timings. This will for instance accept the statsd line
The above line is real and was sent by openstack swift in our environment.
When a timing event with a sample rate set is received, it will be cloned a number of times in order to simulate it being received without a sampling rate set. This is kind of a dirty hack, but I think that it should be fine in practice.