PR #272 continued #283
Merged
PR #272 continued #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #270 Signed-off-by: mhartenbower <matt.hartenbower@gmail.com>
Signed-off-by: mhartenbower <matt.hartenbower@gmail.com>
Signed-off-by: Matthias Rampke <mr@soundcloud.com>
Following the lead of prometheus/prometheus, we prefer to log-and-exit instead of an unstructured panic. cf. https://github.com/prometheus/prometheus/pull/3061/files#diff-4a3ccbb3ebdcd530af96f0105fe833c2R182 Signed-off-by: Matthias Rampke <mr@soundcloud.com>
|
note for the changelog: the logger change is only mildly breaking – the valid values for |
|
👍 |
| level.Error(logger).Log("msg", "error dumping FSM", "error", err) | ||
| // Failure to dump the FSM is an error (the user asked for it and it | ||
| // didn't happen) but not fatal (the exporter is fully functional | ||
| // afterwards). |
There was a problem hiding this comment.
As an aside, should this always exit anyway? This sounds more like a tool than what a daemon should do in passing.
There was a problem hiding this comment.
hmm it could, yeah, although then I'd prefer to start a mapper CLI which could also do config validation.
matthiasr
pushed a commit
that referenced
this pull request
Jan 10, 2020
Signed-off-by: Matthias Rampke <mr@soundcloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up #272 to get it over the finish line:
cc @mhartenbower