Update client_golang to enable native histograms #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro-stanaka
force-pushed
the
feat/update-golang-prom-client-native-histograms
branch
from
bd13e9f to
a3b2c33
Compare
|
Could you please rebase? That should trigger a new CircleCI build, the previous failure was due to an issue on their end. You can drop the first commit, the library update came in with #476 already. |
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
pedro-stanaka
force-pushed
the
feat/update-golang-prom-client-native-histograms
branch
from
a3b2c33 to
507b0a2
Compare
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
|
CircleCI still won't work 😦 |
|
Strange. Can you try logging into CircleCI with GitHub? That |
|
I pushed your commits into a branch in the main repository, and that seems to have triggered something … |
|
Alright the tests that that triggered passed, that's good enough for me. Thank you for adding this! |
matthiasr
added a commit
that referenced
this pull request
Dec 7, 2022
Signed-off-by: Matthias Rampke <matthias@prometheus.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As of client_golang 1.14+ we have support for sparse histograms. This will start to pave the way to allow the exporter not to need bucket configuration per metric anymore.
On top of that, the current behavior is that buckets are still used in the text exposition format, and only when protobuf is negotiated the new native histograms are used, so it should be safe to upgrade right now without changes for older version of prometheus.