Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCD class instances as return value in deserialize functions #687

Merged
merged 2 commits into from
Sep 26, 2023
Merged

PCD class instances as return value in deserialize functions #687

merged 2 commits into from
Sep 26, 2023

Conversation

cedoor
Copy link
Contributor

@cedoor cedoor commented Sep 25, 2023

Closes #308

@cedoor cedoor assigned cedoor and unassigned cedoor Sep 25, 2023
ichub
ichub requested changes Sep 25, 2023
View reviewed changes
packages/eddsa-pcd/src/EdDSAPCD.ts Outdated Show resolved Hide resolved
@cedoor cedoor force-pushed the cedoor/deserialize-constructors branch from ba1358d to f7e2a7c Compare September 26, 2023 12:13
@cedoor cedoor requested a review from ichub September 26, 2023 15:43
@cedoor cedoor force-pushed the cedoor/deserialize-constructors branch 2 times, most recently from e5e3d75 to 4f02122 Compare September 26, 2023 20:12
@cedoor cedoor force-pushed the cedoor/deserialize-constructors branch from 4f02122 to 62edb43 Compare September 26, 2023 20:29
@cedoor cedoor merged commit 2b63c59 into main Sep 26, 2023
1 check passed
@cedoor cedoor deleted the cedoor/deserialize-constructors branch September 26, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichub ichub ichub approved these changes

@robknight robknight Awaiting requested review from robknight

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@cedoor @robknight @ichub