fix: Add description for ClientError
#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
It's not much better, but at least it helps. 
|
nesium
approved these changes
May 30, 2023
Contributor
nesium
left a comment
nesium
left a comment
There was a problem hiding this comment.
LGTM. Seems like error handling still needs to be more granular in the core lib, but that's definitely an improvement for now. Thanks, Rémi!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to log into Prose macOS, I'm getting
The operation couldn’t be completed. (ProseCoreFFI.ClientError error 0.):Users should not see this, and it doesn't help debugging, so I believe it's better if we add
LocalizedErrorconformance as a quick win.Ideally
ClientErrorshould be localized, but it's an issue for another time.