Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for FFI while leaving legacy implementations intact #11483

Closed
wants to merge 58 commits into from
Closed

Add support for FFI while leaving legacy implementations intact #11483

wants to merge 58 commits into from

Conversation

JasonLunn
Copy link
Contributor

Alternative to #10221

@JasonLunn JasonLunn requested a review from a team as a code owner January 6, 2023 19:41
@JasonLunn JasonLunn requested review from esorot and removed request for a team January 6, 2023 19:41
@JasonLunn JasonLunn added ruby jruby Issues unique to the JRuby interpreter labels Jan 6, 2023
@JasonLunn JasonLunn requested review from haberman and removed request for esorot January 6, 2023 22:38
@JasonLunn JasonLunn requested a review from a team as a code owner January 10, 2023 21:42
haberman
haberman requested changes Jan 13, 2023
View reviewed changes
ruby/lib/google/protobuf/ffi/field_descriptor.rb Outdated Show resolved Hide resolved
ruby/lib/google/protobuf/ffi/field_descriptor.rb Outdated Show resolved Hide resolved
ruby/lib/google/protobuf/ffi/field_descriptor.rb Outdated Show resolved Hide resolved
ruby/lib/google/protobuf/ffi/field_descriptor.rb Show resolved Hide resolved
ruby/lib/google/protobuf/ffi/ffi.rb Outdated Show resolved Hide resolved
ruby/lib/google/protobuf/ffi/field_descriptor.rb Show resolved Hide resolved
ruby/lib/google/protobuf/ffi/descriptor.rb Outdated Show resolved Hide resolved
ruby/lib/google/protobuf/ffi/descriptor.rb Outdated Show resolved Hide resolved
ruby/lib/google/protobuf/ffi/descriptor.rb Outdated Show resolved Hide resolved
ruby/lib/google/protobuf/ffi/descriptor.rb Outdated Show resolved Hide resolved
@haberman haberman mentioned this pull request Feb 16, 2023
Closed
@JasonLunn JasonLunn requested review from a team as code owners July 7, 2023 11:47
@JasonLunn JasonLunn requested review from dmaclach and removed request for a team July 7, 2023 11:47
@JasonLunn JasonLunn added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 14, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 14, 2023
@JasonLunn JasonLunn added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 14, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 14, 2023
@JasonLunn JasonLunn added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 14, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 14, 2023
@JasonLunn
Move most calls to attach_function out of ffi.rb.
e28e256 
Allows reordering of `require` statements in `protobuf_ffi.b` so that failed attempts load `ffi/ffi.rb` can be recovered in `protobuf.rb` without having to undo constant definitions when falling back from FFI to native implementations.
@JasonLunn
Breakout conformance tests by platform and whether FFI is enabled.
55f2884
@JasonLunn JasonLunn added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 15, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 15, 2023
@JasonLunn JasonLunn added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 15, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 15, 2023
@JasonLunn JasonLunn added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 15, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 15, 2023
@JasonLunn JasonLunn added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 16, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 16, 2023
@JasonLunn JasonLunn requested a review from haberman July 17, 2023 01:19
@JasonLunn JasonLunn added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 17, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 17, 2023
@JasonLunn
Make all interpreters opt-in for FFI.
839a3d7 
Rename `backend.rb` to `implementation.rb`.
@JasonLunn JasonLunn added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 18, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 18, 2023
@JasonLunn JasonLunn mentioned this pull request Jul 18, 2023
Closed
@JasonLunn
Copy link
Contributor Author

Closing in favor of #13343 where test configurations are added.

@JasonLunn JasonLunn closed this Jul 18, 2023
copybara-service bot pushed a commit that referenced this pull request Jul 25, 2023
@JasonLunn @copybara-github
Ruby FFI implementation (#13343)
c52d80c 
Supersedes #11483.

Closes #13343

COPYBARA_INTEGRATE_REVIEW=#13343 from protocolbuffers:simultaneous_ffi bcb4bb7
PiperOrigin-RevId: 550782245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Logofile Logofile Logofile left review comments

@mkruskal-google mkruskal-google mkruskal-google left review comments

@haberman haberman Awaiting requested review from haberman

Assignees

@haberman haberman

@mkruskal-google mkruskal-google

Labels
jruby Issues unique to the JRuby interpreter ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JasonLunn @jskeet @haberman @mkruskal-google @Logofile @protobuf-kokoro @zhangskz