Change Python kokoro configs to test only their specified version. #7927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using non-versioned `build_file` values means every Python version is tested (under Tox), and this is multiplied by each Python version running Tox. For example, this means that when the `python38` config is used to run Tox, the Tox layer runs on Python 3.8, and which then tests all of the Python versions individually. As a result, tests are run under Python 3.8 for every runner configuration. This change fixes the `build_file` paths to point to the correct paths.
dlj-NaN
added
conformance tests
python
testing
release notes: no
and removed
conformance tests
labels
|
FYI, the latest Kokoro tests used the Docker images with the changes in this patch. Only the Python images were rebuilt (the macOS failures in particular are pre-existing). |
haberman
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our versioned Python tests have been using the common "linux/64-bit" runner
with the same
kokoro/linux/python_cpp/build.shbuild script. Unfortunately,using non-versioned
build_filemeans every Python version is tested (underTox), multiplied across each Python version-specific build.
For example, this means that when the
python38config is used to run Tox, theTox runner actually uses the default Python from
kokoro/linux/64-bit, whichthen tests all of the Python versions individually, via Tox.
This change fixes the
build_filepaths to point to the version-specific buildscripts. Because all of the builds were running on the
linux/64-bitimage, thischange also updates the versioned build containers to install tox.
Some tox.ini changes are needed to avoid breakage (see also #7930).