Expose methods needed by Ruby FFI using UPB_API #1391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haberman
requested changes
Jul 10, 2023
JasonLunn
changed the title
haberman
approved these changes
Jul 10, 2023
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 10, 2023
Once merged, the changes to ~`upb-ruby.h`~ `glue.c` in protocolbuffers/protobuf#11483 can be reverted without breaking the FFI feature branch. Closes #1391 FUTURE_COPYBARA_INTEGRATE_REVIEW=#1391 from JasonLunn:ffi 5c3a5b8 PiperOrigin-RevId: 546977111
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
Once merged, the changes to ~`upb-ruby.h`~ `glue.c` in protocolbuffers/protobuf#11483 can be reverted without breaking the FFI feature branch. Closes #1391 FUTURE_COPYBARA_INTEGRATE_REVIEW=#1391 from JasonLunn:ffi 5c3a5b8 PiperOrigin-RevId: 546977111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once merged, the changes to
upb-ruby.hglue.cin protocolbuffers/protobuf#11483 can be reverted without breaking the FFI feature branch.