Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add /health endpoint returning 200 OK #1155

Closed
analytically opened this issue Nov 14, 2019 · 2 comments · Fixed by #1156
Closed

Add /health endpoint returning 200 OK #1155

analytically opened this issue Nov 14, 2019 · 2 comments · Fixed by #1156
Assignees
@prymitive
Labels
enhancement New feature or request

Comments

@analytically
Copy link

Handy for schedulers like Nomad and K8s to have a /health endpoint indicating service availability.
@analytically
Copy link
Author

Currently when using / it looks ugly:

image

@prymitive prymitive self-assigned this Nov 14, 2019
@prymitive
Copy link
Owner

Good idea, I've been using /alerts.json?q=%40limit%3D1 or /manifest.json, having a dedicated /health would be nice.
Do you think that a dummy 200 OK is enough for this?

@prymitive prymitive added the enhancement New feature or request label Nov 14, 2019
prymitive added a commit that referenced this issue Nov 14, 2019
@prymitive
feat(backend): add /health endpoint for healthcheck probes
3b2534e 
Fixes #1155
@prymitive prymitive mentioned this issue Nov 14, 2019
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@prymitive prymitive

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(backend): add /health endpoint for healthcheck probes prymitive/karma
2 participants
@prymitive @analytically