Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add X-WEBAUTH-USER header #739

Closed
wants to merge 3 commits into from
Closed

Conversation

cawfeecoder
Copy link

Adding the X-WEBAUTH-USER header to support enterprise applications where authentication happens at a proxy in front of the application using X509/PKI and the username is passed through via header.

…henticating proxy. Modify default refresh interval.
Add X-WEBAUTH-USER header to pre-populate users coming through an aut…
@cawfeecoder
Copy link
Author

@prymitive I'll fix this up tonight so it's currently failing test.

@prymitive
Copy link
Owner

What is the intention behind this? Is it just to pre-populate the author field or to force specific author in silences? Author field value is stored in localStorage so once you input something it will be remembered for future silences.
On top of that I have a few generic comments:

  • There's a bunch of go modules changes that seem unrelated
  • Using cookies to communicate between the backend and frontend is not the right way, there's an API for that
  • There are more possible headers than X-WEBAUTH-USER that can be used for authentication, I don't think that adding code that deals specifically with that one header is the best way. Adding a config option to specify a header name and a way of extracting it (maybe via regex) seems like a more generic way.

@prymitive prymitive self-assigned this Jul 3, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants