Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore G307 for Gosec #9790

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Ignore G307 for Gosec #9790

merged 1 commit into from
Oct 18, 2021

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Oct 18, 2021

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

  • The gosec analyzer has started failing PRs for false positives(G307). All our errors for file closes are checked(enforced by errCheck analyzer.) This PR ignores it for now until gosec has a solution that fixes this in its following releases.

Which issues(s) does this PR fix?

securego/gosec#714

Other notes for review

@nisdas nisdas added the Ready For Review A pull request ready for code review label Oct 18, 2021
@nisdas nisdas requested a review from a team as a code owner October 18, 2021 03:41
@rkapka rkapka merged commit d1f3050 into develop Oct 18, 2021
@rkapka rkapka deleted the nisdas-patch-1 branch October 18, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkapka rkapka rkapka approved these changes

@terencechain terencechain Awaiting requested review from terencechain terencechain is a code owner automatically assigned from prysmaticlabs/core-team

@james-prysm james-prysm Awaiting requested review from james-prysm james-prysm is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nisdas @rkapka