From d8e6ab8d6229d4f33611eebbf5f5f22f7f069f80 Mon Sep 17 00:00:00 2001
From: Humanalgorithm <scottomj@gmail.com>
Date: Wed, 16 Aug 2023 19:09:53 +0800
Subject: [PATCH] respond shane comments part 1

---
 contracts/factories/base-factory/Cargo.toml              | 4 ++--
 contracts/factories/vending-factory/src/contract.rs      | 1 -
 .../setup_minter/open_edition_minter/mock_params.rs      | 9 ---------
 3 files changed, 2 insertions(+), 12 deletions(-)

diff --git a/contracts/factories/base-factory/Cargo.toml b/contracts/factories/base-factory/Cargo.toml
index e7cb8161b..e4b079d2d 100644
--- a/contracts/factories/base-factory/Cargo.toml
+++ b/contracts/factories/base-factory/Cargo.toml
@@ -35,7 +35,7 @@ schemars        = { workspace = true }
 serde           = { workspace = true }
 sg1             = { workspace = true }
 sg2             = { workspace = true }
-cw721-base = { workspace = true }
-sg721-base      = { workspace = true} 
+cw721-base = { workspace = true, features = ["library"] }
+sg721-base      = { workspace = true, features = ["library"]} 
 sg-std          = { workspace = true }
 thiserror       = { workspace = true }
diff --git a/contracts/factories/vending-factory/src/contract.rs b/contracts/factories/vending-factory/src/contract.rs
index 7cf6dc917..298db6ab4 100644
--- a/contracts/factories/vending-factory/src/contract.rs
+++ b/contracts/factories/vending-factory/src/contract.rs
@@ -82,7 +82,6 @@ pub fn execute_create_minter(
             got: msg.init_msg.per_address_limit,
         });
     }
-    //TODO BURNMINT
     let denom_min_mint_price = params.min_mint_price.clone().denom()?;
     ensure!(
         denom_min_mint_price == msg.init_msg.mint_price.denom,
diff --git a/test-suite/src/common_setup/setup_minter/open_edition_minter/mock_params.rs b/test-suite/src/common_setup/setup_minter/open_edition_minter/mock_params.rs
index 03d21a123..cb34e5f03 100644
--- a/test-suite/src/common_setup/setup_minter/open_edition_minter/mock_params.rs
+++ b/test-suite/src/common_setup/setup_minter/open_edition_minter/mock_params.rs
@@ -61,15 +61,6 @@ pub fn mock_create_minter_init_msg(
     }
 }
 
-//     start_minter_time: Option<Timestamp>,
-//     end_minter_time: Option<Timestamp>,
-//     nft_data: Option<NftData>,
-//     max_per_address_limit: Option<u32>,
-//     per_address_limit_minter: Option<u32>,
-//     mint_price_minter: Option<Coin>,
-//     sg721_code: Option<Box<dyn Contract<StargazeMsgWrapper>>>,
-//     sg721_codeid: Option<u64>,
-
 pub fn mock_params_proper() -> OpenEditionMinterParams {
     OpenEditionMinterParams {
         code_id: 1,