Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SG-997 Add IBC denoms to open edition #596

Merged
merged 28 commits into from
Aug 19, 2023

Conversation

yubrew
Copy link
Contributor

@yubrew yubrew commented Jul 24, 2023

ibc denoms for open edition minter (frenz)

I ran e2e tests locally and they passed

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 74.69% and project coverage change: +0.88% 🎉

Comparison is base (8065104) 59.52% compared to head (9ada038) 60.40%.
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
+ Coverage   59.52%   60.40%   +0.88%     
==========================================
  Files          83       85       +2     
  Lines        4212     4521     +309     
==========================================
+ Hits         2507     2731     +224     
- Misses       1705     1790      +85     
Files Changed Coverage Δ
...acts/collections/sg721-metadata-onchain/src/lib.rs 0.00% <ø> (ø)
...tracts/collections/sg721-updatable/src/contract.rs 56.69% <0.00%> (-8.53%) ⬇️
contracts/sg-eth-airdrop/src/claim_airdrop.rs 96.92% <0.00%> (ø)
e2e/src/helpers/helper.rs 0.00% <0.00%> (ø)
...on_setup/setup_minter/open_edition_minter/setup.rs 6.55% <0.00%> (ø)
...suite/src/common_setup/setup_accounts_and_block.rs 93.61% <25.00%> (ø)
...cts/factories/open-edition-factory/src/contract.rs 93.05% <78.57%> (-2.19%) ⬇️
packages/sg1/src/lib.rs 89.58% <82.60%> (-6.42%) ⬇️
...tracts/minters/open-edition-minter/src/contract.rs 80.05% <100.00%> (+0.40%) ⬆️
...src/common_setup/setup_minter/base_minter/setup.rs 100.00% <100.00%> (ø)
... and 3 more

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yubrew yubrew marked this pull request as ready for review July 24, 2023 22:27
@yubrew yubrew changed the title Add ibc denoms to open edition SG-997 Add ibc denoms to open edition Jul 26, 2023
@linear
Copy link

linear bot commented Jul 26, 2023

@shanev shanev changed the title SG-997 Add ibc denoms to open edition SG-997 Add IBC denoms to open edition Jul 28, 2023
Copy link
Member

@shanev shanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides some minor refactoring.

I wanted to start using Typescript for e2e tests but since this already has Rust-based tests, it's fine that it's continued. I understand that its beyond the scope of this PR to do that.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Cosm-Orc Gas Usage

Contract Op Name Gas Used Old Gas Used Gas Diff File
open_edition_minter Store__Store 8493792 8399048 +1.1280% e2e/src/helpers/chain.rs:78
multiple_contracts Execute__minter_batch_exec_mint_token_w_trading_time 1941466 3108031 -37.5339% e2e/src/tests/factory_test.rs:314
multiple_contracts Execute__minter_batch_exec_mint_token 1584770 18814983 -91.5771% e2e/src/tests/open_edition_minter_executes_tests.rs:142
Raw Report for 9ada038
Contract Op Name Gas Used Gas Wanted File
base_factory Store__Store 2665605 3975267 e2e/src/helpers/chain.rs:78
base_minter Store__Store 6995048 10469372 e2e/src/helpers/chain.rs:78
open_edition_factory Store__Store 3434360 5128400 e2e/src/helpers/chain.rs:78
open_edition_factory Execute__factory_exec_minter_inst_w_trading_time 542350 790400 e2e/src/tests/open_edition_factory_and_mint_tests.rs:405
open_edition_factory Instantiate__factory_inst 186625 256820 e2e/src/helpers/open_edition_minter_helpers.rs:39
open_edition_factory Execute__factory_exec_minter_inst 541640 789335 e2e/src/tests/open_edition_minter_executes_tests.rs:59
open_edition_minter Store__Store 8493792 12717488 e2e/src/helpers/chain.rs:78
sg721_base Store__Store 8382096 12549944 e2e/src/helpers/chain.rs:78
sg721_metadata_onchain Store__Store 8832975 13226262 e2e/src/helpers/chain.rs:78
sg721_nt Store__Store 7781314 11648771 e2e/src/helpers/chain.rs:78
sg721_updatable Store__Store 9157273 13712709 e2e/src/helpers/chain.rs:78
sg_whitelist Store__Store 3582040 5349920 e2e/src/helpers/chain.rs:78
sg_whitelist_flex Store__Store 3519822 5256593 e2e/src/helpers/chain.rs:78
vending_factory Store__Store 3044906 4544219 e2e/src/helpers/chain.rs:78
vending_factory Instantiate__factory_inst 187313 257853 e2e/src/helpers/helper.rs:35
vending_factory Execute__factory_exec_minter_inst 34037401 51032895 e2e/src/tests/factory_test.rs:98
vending_factory Execute__factory_exec_minter_inst_w_trading_time 3857605 5763207 e2e/src/tests/factory_test.rs:244
vending_minter Store__Store 8757887 13113630 e2e/src/helpers/chain.rs:78
vending_minter_wl_flex Store__Store 8935500 13380045 e2e/src/helpers/chain.rs:78
whitelist_immutable Store__Store 2195122 3269543 e2e/src/helpers/chain.rs:78
multiple_contracts Execute__minter_batch_exec_mint_token_w_trading_time 1941466 2893755 e2e/src/tests/factory_test.rs:314
multiple_contracts Execute__minter_batch_exec_mint_token 1584770 2354274 e2e/src/tests/open_edition_minter_executes_tests.rs:142
minter Execute__minter_exec_mint_to_token 363965 522825 e2e/src/tests/open_edition_minter_executes_tests.rs:180
minter Execute__minter_exec_purge 139026 185472 e2e/src/tests/open_edition_minter_executes_tests.rs:281
minter Execute__minter_exec_update_per_addr_limit 209170 290637 e2e/src/tests/open_edition_minter_executes_tests.rs:216
minter Execute__minter_exec_update_trading_time 271327 383871 e2e/src/tests/open_edition_minter_executes_tests.rs:99

@shanev
Copy link
Member

shanev commented Aug 15, 2023

@yubrew We can update to use the Fair Burn contract now since its on mainnet yeah?

pub airdrop_mint_price_amount: Option<Uint128>,
}

pub const DEFAULT_CUSTOM_PARAMS: OpenEditionMinterCustomParams = OpenEditionMinterCustomParams {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can use the Default trait here

@yubrew
Copy link
Contributor Author

yubrew commented Aug 17, 2023

@yubrew We can update to use the Fair Burn contract now since its on mainnet yeah?

config.fee_percent is 50%, this contract needs a different percent.
https://github.com/public-awesome/core/blob/main/contracts/fair-burn/src/helpers.rs#L9

@shanev shanev merged commit 13e288d into main Aug 19, 2023
@shanev shanev deleted the yubrew/add-ibc-denoms-to-open-edition branch August 19, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants