New Feature #137: Implement withIoC={CDI, CDI_SINGLETON} options #141
Conversation
|
Hi thanks for the pull request, as you can see there is an Exception in Selma is not able to find the generated Mapper class. To be able to run the tests you can simply launch the build with maven. I personnaly use IntelliJ to run tests. |
| @Test | ||
| public void given_cdi_mapper_should_be_annotated_with_Inject_and_Singleton() { | ||
|
|
||
| final CustomCdiMapperInMaps mapper = Selma.getMapper(CustomCdiMapperInMaps.class); |
There was a problem hiding this comment.
Mapper here should be CustomCdiSingletonMapperInMaps not CustomCdiMapperInMaps.
| /** Adds @Inject annotation to the generated mapper */ | ||
| CDI, | ||
| /** Adds @Inject and @Singleton annotations to the generated mapper */ | ||
| CDI_SINGLETON, |
There was a problem hiding this comment.
I am not sure why we should create 3 different values for CDI. Why don't you consider @Singleton as required for CDI.
| /** Adds @Inject and @Singleton annotations to the generated mapper */ | ||
| CDI_SINGLETON, | ||
| /** Adds @ApplicationScoped annotation to the generated mapper */ | ||
| CDI_APPLICATION_SCOPED |
There was a problem hiding this comment.
Same as for singleton @ApplicationScoped can be the standard way.
|
Hi, first of all, let me apologize for the unintended changes I pushed before. For some reason I still ignore, I had my Eclipse formatter configured to use tabs, as you pointed out. I have updated my formatter to use 4 spaces instead of tabs. All the modified classes should have now spaces instead of tabs. In addition to that, after removing the tabs, I could validate that the tests were passing in my local this time. I don't know the reason why tabs caused such a huge impact in the code, but the important thing is that it's now solved. I have also corrected the mapper being used in one of my test classes, as you pointed out. It clearly was a side effect of a too fast copy-and-paste maneuver. Finally, the reason why I added I hope everything is good know. However, please, do not hesitate to let me know if anything else is needed from my side. Thank you! |
|
Hi thanks for the great work, It's all good for me :) |
Hi,
I've tried implementing the feature #137 I requested a few days ago. The code I've written looks like it works, but I honestly didn't manage to find a way to get the tests running. I've implemented a couple of new tests classes that are supposed to work, but again, since I couldn't make them run, I cannot confirm at 100%. I've been able to create another project and validate the generated mapper classes are good though.
I'm using Eclipse and Java 8. If you tell me how to run tests, I can try again. Nevertheless, you can see what you get, and if everything looks good to you, maybe you can merge the code straightway.
Please, let me know if you find anything that requires improvement.
Bes regards.