Refactor error messages in Ruby on Rails forms to get rid of "dynamic_form" gem

[jywarren]

We use the dynamic_form gem in many places for reasons that we can't even remember -- so if we try to remove that gem, as we did in #4575, tests fail. So let's fix this all and then circle back to that pull request to finish up!

Let's go through the uses of this gem everywhere we can find it and replace it with a more modern and standard form syntax! They look like this, using the error_messages property of the form_for block:

<%= form_for :revision, :as => :revision, :url => url, :html => {:class => "form"} do \|f\| %>
  <% if f.error_messages != "" %>
    <div class="alert alert-danger"><%= f.error_messages :header_message => "Your note couldn't be saved." %></div>
  <% end %>
<% end %>

But they should look like this:

  <% if @model.errors.any? %>
    <div id="error_explanation">
      <h2><%= pluralize(@model.errors.count, "error") %> prohibited this model from being saved:</h2>
      <ul>
      <% @model.errors.full_messages.each do |msg| %>
        <li><%= msg %></li>
      <% end %>
      </ul>
    </div>
  <% end %>

We can search to find where changes should be made, and the simpler of these may potentially be good first-timers-only issues, although if updating these cause tests to need updating too, that could be a potential barrier for a newcomer, so let's be sure to support people well in these!

Here are many instances that could be broken out into their own issues:

https://github.com/publiclab/plots2/search?q=error_messages&unscoped_q=error_messages

• plots2/app/views/features/new.html.erb

  Line 10 in c60aaab

  <% if f.error_messages != "" %><div class="alert alert-danger"><%= f.error_messages :header_message => "Your note couldn't be saved." %></div><% end %>

• plots2/app/views/users/_edit_form.html.erb

  Line 5 in c60aaab

  <% if f.error_messages != "" %>

• plots2/app/views/editor/question.html.erb

  Line 68 in c60aaab

  <% if f.error_messages != "" %><div class="alert alert-danger"><%= f.error_messages :header_message => "Your note couldn't be saved." %></div><% end %>

(we can keep adding links to instances in this list, as they are completed and checked off!)

[jywarren]

I've made a first-timers-only issue from one of these! See how it looks to perform one of these updates by seeing this commit:

eada0c0

[stacytonui]

Hey can I try working on this?

[jywarren]

Hi @stacytonui -- sure, can you choose one from the checklist above, and open a pull request with that one file change, similar to eada0c0 ? And link to it from here? Thank you so much!

[stacytonui]

Okay let me work on the first one

[stacytonui]

@jywarren apologies for the first PR, my repo wasn't synced with the main one

[noi5e]

@jywarren I'd like to work on the second one in plots2/app/views/users/_edit_form.html.erb if you can reserve it for me :) Will make a PR.

[diorshelton]

Can I give this a shot with plots2/app/views/map/edit.html.erb ?

[diorshelton]

diorshelton#1 (comment)

[jywarren]

Hi, @diorshelton - I'd love your help - but unfortunately the map/edit.html.erb file is the one I opened up a "first-timers-only" issue for and reserved for @Asu1996 here - #8546

Would you be willing to take on a different one from the list, or from the search results above? Your code looks great! Thank you for your understanding!

@noi5e I'll check out yours now, thank you too!

[jywarren]

Hi @noi5e - are you working on this in #8553 ? Need any help with the errors you're seeing? No worries, I'm here to support!

[Cadreia]

Hi, @jywarren can I work on question.html.erb?

[noi5e]

@jywarren Yes, will reply to you in the PR, thank you!

[jywarren]

Hi, @jywarren can I work on question.html.erb?

Yes, that would be great!!!

[noi5e]

@jywarren - Looks like there are two instances in post.html.erb:

plots2/app/views/editor/post.html.erb

Line 66 in a591541

<% if f.error_messages != "" %><div class="alert alert-danger"><%= f.error_messages :header_message => "Your note couldn't be saved." %></div><% end %>

plots2/app/views/editor/post.html.erb

Line 72 in a591541

<% if f.error_messages != "" %><div class="alert alert-danger"><%= f.error_messages :header_message => "Your note couldn't be saved." %></div><% end %>

Happy to give these a shot if that's okay!