Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename answered to recently commented #7257

Merged
merged 2 commits into from
Oct 7, 2020

Conversation

priyanka-choubey
Copy link
Contributor

@priyanka-choubey priyanka-choubey commented Jan 16, 2020

Fixes #7075

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

GIF

Hnet-image

@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #7257 into main will increase coverage by 20.62%.
The diff coverage is 83.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #7257       +/-   ##
===========================================
+ Coverage   61.25%   81.87%   +20.62%     
===========================================
  Files          97      101        +4     
  Lines        5709     5899      +190     
===========================================
+ Hits         3497     4830     +1333     
+ Misses       2212     1069     -1143     
Impacted Files Coverage Δ
app/models/concerns/statistics.rb 96.72% <ø> (ø)
app/models/drupal_content_type_map.rb 92.59% <ø> (+35.44%) ⬆️
app/mailers/admin_mailer.rb 90.90% <12.50%> (-9.10%) ⬇️
app/jobs/digest_spam_job.rb 33.33% <33.33%> (ø)
app/models/user.rb 87.68% <47.61%> (-1.38%) ⬇️
app/controllers/spam2_controller.rb 71.84% <71.84%> (ø)
app/controllers/users_controller.rb 81.11% <80.00%> (+29.70%) ⬆️
app/models/comment.rb 77.51% <83.33%> (+3.23%) ⬆️
app/controllers/notes_controller.rb 83.46% <85.71%> (+41.14%) ⬆️
app/controllers/batch_controller.rb 90.19% <90.19%> (ø)
... and 67 more

@priyanka-choubey
Copy link
Contributor Author

@jywarren @cesswairimu not really sure why the tests are failing 😅

@Uzay-G
Copy link
Member

Uzay-G commented Jan 16, 2020

Hey @jywarren could you rerun the build. We don't have permissions for this repo but I don't think @priyanka-choubey's changes are making this fail.
Thanks 👍

config/routes.rb Show resolved Hide resolved
@LeoDog896
Copy link

Looks fine to me! @jywarren's change should be added, but after that this is definitely ready for a merge!

@jywarren jywarren changed the base branch from master to main June 30, 2020 18:02
@cesswairimu
Copy link
Collaborator

Re-triggering travis

@cesswairimu cesswairimu reopened this Sep 18, 2020
@jywarren
Copy link
Member

jywarren commented Oct 1, 2020

I think i made the backwards-compatible route redirect change!

@jywarren jywarren merged commit 4009469 into publiclab:main Oct 7, 2020
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
* Rename answered to recently commented

* Update config/routes.rb

Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
* Rename answered to recently commented

* Update config/routes.rb

Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
* Rename answered to recently commented

* Update config/routes.rb

Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
* Rename answered to recently commented

* Update config/routes.rb

Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
* Rename answered to recently commented

* Update config/routes.rb

Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
* Rename answered to recently commented

* Update config/routes.rb

Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
* Rename answered to recently commented

* Update config/routes.rb

Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* Rename answered to recently commented

* Update config/routes.rb

Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename answered to recently_commented
5 participants