-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Following and Followers page UI #8372
Conversation
also fixed extra spacing when no tags on the modal
Codecov Report
@@ Coverage Diff @@
## main #8372 +/- ##
==========================================
+ Coverage 81.28% 81.87% +0.59%
==========================================
Files 101 101
Lines 5872 5899 +27
==========================================
+ Hits 4773 4830 +57
+ Misses 1099 1069 -30
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesomeee looks great!!! 😄
Would it look better if we show something like you are not following anyone yet and you have no followrers instead of blank space? Thoughts?
@renugasaraswathy kindly checkout @sagarpreet-chadha comment above. Thanks |
Ig you should mention plots2-reviewers next time. I am of no use here 😂 |
Hi @cesswairimu @sagarpreet-chadha, Apologies I missed the comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@renugasaraswathy LGTM 🎉 Thanks for working on this!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic 🎉 thanks for working on this. Looks great
Wow, so great!!! Thanks so much, to everyone!!! 🎉 |
This is so cool. Actually where is this page linked from? It's not on the profile page, so I wonder if we ought to open a first-timers issue to add a link there - maybe in the list of "stats" on bottom right of the profile page -- like at https://publiclab.org/profile/liz, we could add it here: What do you think? And, @renugasaraswathy would you have any interest in welcoming someone else to the community by creating such an issue? Here is some info on the process, if you're interested! This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping |
Hi @cesswairimu, @publiclab/reviewers is my changes merged to the Public Lab website? I still see old UI in the followers page |
Right now they are at staging, stable.publiclab.org they will go live during o the next deployment. |
* adding tags in modals of Nodes publiclab#8230 * refactored publiclab#8230 * fixed tag path in the modal publiclab#8230 also fixed extra spacing when no tags on the modal * publiclab#8277 & publiclab#8278 changed UI for Following and Followers page * publiclab#8277 updating no followers / following message
* adding tags in modals of Nodes publiclab#8230 * refactored publiclab#8230 * fixed tag path in the modal publiclab#8230 also fixed extra spacing when no tags on the modal * publiclab#8277 & publiclab#8278 changed UI for Following and Followers page * publiclab#8277 updating no followers / following message
* adding tags in modals of Nodes publiclab#8230 * refactored publiclab#8230 * fixed tag path in the modal publiclab#8230 also fixed extra spacing when no tags on the modal * publiclab#8277 & publiclab#8278 changed UI for Following and Followers page * publiclab#8277 updating no followers / following message
* adding tags in modals of Nodes publiclab#8230 * refactored publiclab#8230 * fixed tag path in the modal publiclab#8230 also fixed extra spacing when no tags on the modal * publiclab#8277 & publiclab#8278 changed UI for Following and Followers page * publiclab#8277 updating no followers / following message
* adding tags in modals of Nodes publiclab#8230 * refactored publiclab#8230 * fixed tag path in the modal publiclab#8230 also fixed extra spacing when no tags on the modal * publiclab#8277 & publiclab#8278 changed UI for Following and Followers page * publiclab#8277 updating no followers / following message
* adding tags in modals of Nodes publiclab#8230 * refactored publiclab#8230 * fixed tag path in the modal publiclab#8230 also fixed extra spacing when no tags on the modal * publiclab#8277 & publiclab#8278 changed UI for Following and Followers page * publiclab#8277 updating no followers / following message
* adding tags in modals of Nodes publiclab#8230 * refactored publiclab#8230 * fixed tag path in the modal publiclab#8230 also fixed extra spacing when no tags on the modal * publiclab#8277 & publiclab#8278 changed UI for Following and Followers page * publiclab#8277 updating no followers / following message
* adding tags in modals of Nodes publiclab#8230 * refactored publiclab#8230 * fixed tag path in the modal publiclab#8230 also fixed extra spacing when no tags on the modal * publiclab#8277 & publiclab#8278 changed UI for Following and Followers page * publiclab#8277 updating no followers / following message
Fixes #8277 and #8278
Hi,
I have worked on the UI for Followers & Following page of users
Following URL - /people/username/following
Followers URL - /people/username/followers
Pagination is implemented for the same with 10 items per page
Screenshots of the same are attached below.
@publiclab/reviewers, Please review and provide feedback.
Thanks