Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Following and Followers page UI #8372

Merged
merged 6 commits into from
Sep 30, 2020
Merged

Following and Followers page UI #8372

merged 6 commits into from
Sep 30, 2020

Conversation

renugasaraswathy
Copy link
Contributor

Fixes #8277 and #8278
Hi,

I have worked on the UI for Followers & Following page of users

Following URL - /people/username/following
Followers URL - /people/username/followers
Pagination is implemented for the same with 10 items per page

Screenshots of the same are attached below.

image

image

image

@publiclab/reviewers, Please review and provide feedback.

Thanks

@renugasaraswathy renugasaraswathy requested a review from a team as a code owner September 2, 2020 04:57
@gitpod-io
Copy link

gitpod-io bot commented Sep 2, 2020

@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #8372 into main will increase coverage by 0.59%.
The diff coverage is 90.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8372      +/-   ##
==========================================
+ Coverage   81.28%   81.87%   +0.59%     
==========================================
  Files         101      101              
  Lines        5872     5899      +27     
==========================================
+ Hits         4773     4830      +57     
+ Misses       1099     1069      -30     
Impacted Files Coverage Δ
app/models/drupal_content_type_map.rb 92.59% <ø> (-0.27%) ⬇️
app/controllers/users_controller.rb 81.11% <66.66%> (ø)
app/controllers/spam2_controller.rb 71.84% <84.61%> (+10.30%) ⬆️
app/controllers/tag_controller.rb 81.40% <88.00%> (ø)
app/models/node.rb 91.51% <92.85%> (+0.33%) ⬆️
app/controllers/admin_controller.rb 80.24% <100.00%> (ø)
app/controllers/application_controller.rb 92.24% <100.00%> (+0.06%) ⬆️
app/controllers/batch_controller.rb 90.19% <100.00%> (+22.23%) ⬆️
app/controllers/comment_controller.rb 86.95% <100.00%> (ø)
app/controllers/home_controller.rb 98.38% <100.00%> (ø)
... and 8 more

Copy link
Contributor

@sagarpreet-chadha sagarpreet-chadha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesomeee looks great!!! 😄
Would it look better if we show something like you are not following anyone yet and you have no followrers instead of blank space? Thoughts?

@cesswairimu
Copy link
Collaborator

@renugasaraswathy kindly checkout @sagarpreet-chadha comment above. Thanks

@harshkhandeparkar
Copy link
Member

Ig you should mention plots2-reviewers next time. I am of no use here 😂

@renugasaraswathy
Copy link
Contributor Author

Hi @cesswairimu @sagarpreet-chadha,

Apologies I missed the comment.
I have updated the messages as given in the screenshots below. Please review.

Screenshot 2020-09-30 at 9 55 30 AM

image

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renugasaraswathy LGTM 🎉 Thanks for working on this!!

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic 🎉 thanks for working on this. Looks great

@cesswairimu cesswairimu merged commit 07b03d0 into publiclab:main Sep 30, 2020
@jywarren
Copy link
Member

jywarren commented Oct 1, 2020

Wow, so great!!! Thanks so much, to everyone!!! 🎉

@jywarren
Copy link
Member

jywarren commented Oct 1, 2020

This is so cool. Actually where is this page linked from? It's not on the profile page, so I wonder if we ought to open a first-timers issue to add a link there - maybe in the list of "stats" on bottom right of the profile page -- like at https://publiclab.org/profile/liz, we could add it here:

image

What do you think? And, @renugasaraswathy would you have any interest in welcoming someone else to the community by creating such an issue? Here is some info on the process, if you're interested!


This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labelled. Or, if this is not your first time, try to solve it yourself!

@renugasaraswathy renugasaraswathy deleted the feat-8277 branch October 5, 2020 03:58
@renugasaraswathy
Copy link
Contributor Author

renugasaraswathy commented Oct 5, 2020

Hi @jywarren, @publiclab/reviewers I have created the new issue #8453. Please review.

Thanks everyone for helping me in this pull request.

@renugasaraswathy
Copy link
Contributor Author

renugasaraswathy commented Oct 5, 2020

Hi @cesswairimu, @publiclab/reviewers is my changes merged to the Public Lab website? I still see old UI in the followers page

@cesswairimu
Copy link
Collaborator

Right now they are at staging, stable.publiclab.org they will go live during o the next deployment.

shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal

* publiclab#8277 & publiclab#8278 changed UI for Following and Followers page

* publiclab#8277 updating no followers / following message
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal

* publiclab#8277 & publiclab#8278 changed UI for Following and Followers page

* publiclab#8277 updating no followers / following message
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal

* publiclab#8277 & publiclab#8278 changed UI for Following and Followers page

* publiclab#8277 updating no followers / following message
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal

* publiclab#8277 & publiclab#8278 changed UI for Following and Followers page

* publiclab#8277 updating no followers / following message
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal

* publiclab#8277 & publiclab#8278 changed UI for Following and Followers page

* publiclab#8277 updating no followers / following message
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal

* publiclab#8277 & publiclab#8278 changed UI for Following and Followers page

* publiclab#8277 updating no followers / following message
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal

* publiclab#8277 & publiclab#8278 changed UI for Following and Followers page

* publiclab#8277 updating no followers / following message
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal

* publiclab#8277 & publiclab#8278 changed UI for Following and Followers page

* publiclab#8277 updating no followers / following message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine /followers page design
6 participants