Migrate to pagy completely for notes' pagination #8429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## main #8429 +/- ##
=======================================
Coverage 81.87% 81.87%
=======================================
Files 101 101
Lines 5899 5899
=======================================
Hits 4830 4830
Misses 1069 1069
|
|
Wow! Exciting here! What do you think went wrong on the tests? You might want to take a look at @Tlazypanda's PR at https://github.com/publiclab/plots2/pull/8428/files for any tips, as it was able to complete tests. Thank you! |
avats-dev
force-pushed
the
notes-pagy-migration
branch
from
2d46f8f to
35e13bd
Compare
|
@jywarren done 🎉 , tests are passing now. Thanks. |
|
Awesome! Great work!!!! |
shubhangikori
pushed a commit
to shubhangikori/plots2
that referenced
this pull request
Oct 12, 2020
* Add .deepsource.toml * Delete .deepsource.toml * migrate to pagy for notes Co-authored-by: DeepSource Bot <bot@deepsource.io>
alvesitalo
pushed a commit
to alvesitalo/plots2
that referenced
this pull request
Oct 14, 2020
* Add .deepsource.toml * Delete .deepsource.toml * migrate to pagy for notes Co-authored-by: DeepSource Bot <bot@deepsource.io>
piyushswain
pushed a commit
to piyushswain/plots2
that referenced
this pull request
Oct 22, 2020
* Add .deepsource.toml * Delete .deepsource.toml * migrate to pagy for notes Co-authored-by: DeepSource Bot <bot@deepsource.io>
manchere
pushed a commit
to manchere/plots2
that referenced
this pull request
Feb 13, 2021
* Add .deepsource.toml * Delete .deepsource.toml * migrate to pagy for notes Co-authored-by: DeepSource Bot <bot@deepsource.io>
lagunasmel
pushed a commit
to lagunasmel/plots2
that referenced
this pull request
Mar 2, 2021
* Add .deepsource.toml * Delete .deepsource.toml * migrate to pagy for notes Co-authored-by: DeepSource Bot <bot@deepsource.io>
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
* Add .deepsource.toml * Delete .deepsource.toml * migrate to pagy for notes Co-authored-by: DeepSource Bot <bot@deepsource.io>
ampwang
pushed a commit
to ampwang/plots2
that referenced
this pull request
Oct 26, 2021
* Add .deepsource.toml * Delete .deepsource.toml * migrate to pagy for notes Co-authored-by: DeepSource Bot <bot@deepsource.io>
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
* Add .deepsource.toml * Delete .deepsource.toml * migrate to pagy for notes Co-authored-by: DeepSource Bot <bot@deepsource.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In progress to #8426
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowThis fully migrates notes to pagination with pagy along with #8326 .
Depends on #8428 , so that application_controller includes pagy as backend.
Reference :https://ddnexus.github.io/pagy/migration-guide
If tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!