Validate sign up form elements on page reload #8506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## main #8506 +/- ##
==========================================
- Coverage 82.01% 81.89% -0.12%
==========================================
Files 101 101
Lines 5894 5894
==========================================
- Hits 4834 4827 -7
- Misses 1060 1067 +7
|
|
Code Climate has analyzed commit 930e33f and detected 0 issues on this pull request. View more on Code Climate. |
|
This looks awesome. Does it show any errors on initial page load? Thanks! |
|
@jywarren no it won't show any errors on initial page load, I fixed that. Please try it out in gitpod and let me know if any changes are required. 😄 |
|
Awesome. Thanks so much for the fix!!! |
shubhangikori
pushed a commit
to shubhangikori/plots2
that referenced
this pull request
Oct 12, 2020
* Validate sign up form elements on page reload * Refactor validate condition to reduce complexity
piyushswain
pushed a commit
to piyushswain/plots2
that referenced
this pull request
Oct 22, 2020
* Validate sign up form elements on page reload * Refactor validate condition to reduce complexity
manchere
pushed a commit
to manchere/plots2
that referenced
this pull request
Feb 13, 2021
* Validate sign up form elements on page reload * Refactor validate condition to reduce complexity
lagunasmel
pushed a commit
to lagunasmel/plots2
that referenced
this pull request
Mar 2, 2021
* Validate sign up form elements on page reload * Refactor validate condition to reduce complexity
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
* Validate sign up form elements on page reload * Refactor validate condition to reduce complexity
ampwang
pushed a commit
to ampwang/plots2
that referenced
this pull request
Oct 26, 2021
* Validate sign up form elements on page reload * Refactor validate condition to reduce complexity
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
* Validate sign up form elements on page reload * Refactor validate condition to reduce complexity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8463 (<=== Add issue number here)
Reinstates the changes of #7768
Validates the email and username elements of signup form on page reload when an error is faced during sign up. The error could be :
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!