Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix ActiveRecord::RecordNotFound when clicking on 'step-by-step activity'" #9511

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

RuthNjeri
Copy link
Contributor

@RuthNjeri RuthNjeri commented Apr 15, 2021

Reverts #9503

I have just realized that the stable of the production site have the nid we removed...
Here: https://publiclab.org/post?n=15322&title=How%20to%20...&tags=activity:new,draft
and
Here: https://stable.publiclab.org/post?n=15322&title=How%20to%20...&tags=activity:new,draft

@gitpod-io
Copy link

gitpod-io bot commented Apr 15, 2021

@codeclimate
Copy link

codeclimate bot commented Apr 15, 2021

Code Climate has analyzed commit 5c72c09 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@128206c). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head c6726fa differs from pull request most recent head 5c72c09. Consider uploading reports for the commit 5c72c09 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9511   +/-   ##
=======================================
  Coverage        ?   74.12%           
=======================================
  Files           ?       98           
  Lines           ?     6063           
  Branches        ?        0           
=======================================
  Hits            ?     4494           
  Misses          ?     1569           
  Partials        ?        0           

@jywarren
Copy link
Member

Good catch, merging! Thanks, Ruth!!!

@jywarren jywarren merged commit ebaad12 into main Apr 15, 2021
@aliciapaz
Copy link
Contributor

Oooh. So this was a bug only in the development environment?
Thank you for the catch!

@cesswairimu
Copy link
Collaborator

🎉

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants