-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer a template for nginx config files #4654
base: main
Are you sure you want to change the base?
Conversation
I don't think we've sanitized the SSL certificate directory names - some of them don't match the config file names. Before we merge this PR, we may want to:
|
Current failure is:
|
@acozine , @carolyncole, @regineheberlein , and I looked into the test failure. It is an accurate failure: it is complaining about a missing file, and the file is indeed missing from this branch. cleanup-config.yml was the file that was destroying all the nginx configs, so we are pretty sure that we should remove the |
Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com> Co-authored-by: Francis Kayiwa <kayiwa@users.noreply.github.com> Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com> Co-authored-by: Ryan Laddusaw <rladdusaw@users.noreply.github.com> Co-authored-by: Vickie Karasic <vickiekarasic@users.noreply.github.com>
Co-authored-by: Carolyn Cole <carolyncole@users.noreply.github.com> Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com> Co-authored-by: Francis Kayiwa <kayiwa@users.noreply.github.com> Co-authored-by: Ryan Laddusaw <rladdusaw@users.noreply.github.com>
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
…c dirs in main config
…erently now Co-authored-by: Carolyn Cole <carolyncole@users.noreply.github.com> Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com> Co-authored-by: regineheberlein <regineheberlein@users.noreply.github.com>
During Ansible open house we tried to run this PR in it's current state. It did not create the static directory and skipped the steps for some reason. @acozine will add in the command we ran after she returns tomorrow. |
Discussed in Ansible Open Hours: This seems like it's ripe for testing on the dev loadbalancer now that we have it. |
Closes #4349.
Supersedes #4397.
/etc/nginx/conf.d
/static
for static config files (stored as .conf in the nginx role) - we will likely always have static config files for complicated sites/dynamic
for dynamic config files (built from a template and variables in the nginx role)nginx -t
fails