Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downloader exception is checked for http code 200 #617

Closed
mdellweg opened this issue Mar 7, 2022 · 0 comments · Fixed by #620
Closed

Downloader exception is checked for http code 200 #617

mdellweg opened this issue Mar 7, 2022 · 0 comments · Fixed by #620
Assignees
@ipanova
Labels
Issue Triage-Needed

Comments

@mdellweg
Copy link
Member

mdellweg commented Mar 7, 2022

Version
Current main branch.

Describe the bug
A suspicious line of code is found:
https://github.com/pulp/pulp_container/pull/436/files#diff-b702cbd3ebdff19bf8e4dfc14688aa3fb36e1a47ef6cf84d24e0f75b61247d36R89

The downloader will probably not trigger the exception on a 200 response, and therefore the api extensions will never be checked if the registry goes without authentication.
ipanova added a commit to ipanova/pulp_container that referenced this issue Mar 8, 2022
@ipanova
Fixed check for the signature source location.
9dbe0b4 
closes pulp#617
@ipanova ipanova self-assigned this Mar 8, 2022
ipanova added a commit to ipanova/pulp_container that referenced this issue Mar 8, 2022
@ipanova
Fixed check for the signature source location.
ff5709e 
closes pulp#617
@ipanova ipanova mentioned this issue Mar 8, 2022
Merged
ipanova added a commit to ipanova/pulp_container that referenced this issue Mar 8, 2022
@ipanova
Fixed check for the signature source location.
6f7b305 
closes pulp#617
ipanova added a commit to ipanova/pulp_container that referenced this issue Mar 8, 2022
@ipanova
Fixed check for the signature source location.
d156fd5 
closes pulp#617
ipanova added a commit that referenced this issue Mar 9, 2022
@ipanova
Fixed check for the signature source location.
a174126 
closes #617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ipanova ipanova

Labels
Issue Triage-Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed check for the signature source location. ipanova/pulp_container
2 participants
@ipanova @mdellweg