Return all catalog repos when token-auth disabled #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipanova
requested changes
Jun 19, 2024
CHANGES/1651.bugfix
Outdated
| @@ -0,0 +1,2 @@ | |||
| Modified the `_catalog` endpoint to allow non-authed users to see all repos in catalog | |||
| (private and public) even when token-auth is disabled. | |||
pulp_container/app/registry_api.py
Outdated
| @@ -519,6 +519,9 @@ def get_queryset(self, *args, **kwargs): | |||
| distribution_permission = "container.pull_containerdistribution" | |||
| namespace_permission = "container.namespace_pull_containerdistribution" | |||
|
|
|||
| if settings.get("TOKEN_AUTH_DISABLED", True): | |||
There was a problem hiding this comment.
This is dangerous because if the setting is not defined then it will se set to True
Do instead if settings.get("TOKEN_AUTH_DISABLED", False)
With token-auth disabled, allow non-authed users to see all repos (public and private) in catalog. closes: pulp#1651
git-hyagi
force-pushed
the
token-auth-disabled-list
branch
from
8fcd685 to
5f4b85a
Compare
ipanova
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With token-auth disabled, allow non-authed users to see all repos (public and private) in catalog.
closes: #1651