Do not create tags for manifests when pushing by digest #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubosmj
force-pushed
the
push-by-tag-not-supported-852
branch
from
9637aa1 to
e7f433b
Compare
ipanova
reviewed
Jul 1, 2022
| tags_to_remove = models.Tag.objects.filter( | ||
| pk__in=repository.latest_version().content.all(), name=tag | ||
| ).exclude(tagged_manifest=manifest) | ||
| add_content_units = [str(tag.pk), str(manifest.pk)] |
There was a problem hiding this comment.
how about you define add_content_units = [str(manifest.pk)] and remove_content_units= [] empty lists before line 992 and then you just append tag.pk
There was a problem hiding this comment.
this way you will avoid the else block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #852