Minor chunk upload improvements. #2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipanova
added a commit
to ipanova/pulp_container
that referenced
this pull request
May 30, 2022
[noissue] Required PR: pulp/pulpcore#2779
mdellweg
reviewed
May 30, 2022
pulpcore/app/models/upload.py
Outdated
Comment on lines
37
to
38
| upload_chunk = UploadChunk(upload=self, offset=offset, size=len(chunk)) | ||
| upload_chunk = UploadChunk(upload=self, offset=offset, size=len(chunk_read)) |
There was a problem hiding this comment.
This looks like something we could write a test expectation for.
ipanova
added a commit
to ipanova/pulp_container
that referenced
this pull request
May 30, 2022
[noissue] Required PR: pulp/pulpcore#2779
ipanova
added a commit
to ipanova/pulp_container
that referenced
this pull request
May 30, 2022
[noissue] Required PR: pulp/pulpcore#2779
ipanova
added a commit
to ipanova/pulp_container
that referenced
this pull request
May 30, 2022
[noissue] Required PR: pulp/pulpcore#2779
ipanova
added a commit
to ipanova/pulp_container
that referenced
this pull request
May 31, 2022
[noissue] Required PR: pulp/pulpcore#2779
ipanova
added a commit
to ipanova/pulp_container
that referenced
this pull request
Jun 8, 2022
[noissue] Required PR: pulp/pulpcore#2779
ipanova
added a commit
to ipanova/pulp_container
that referenced
this pull request
Jun 14, 2022
closes pulp#797 Required PR: pulp/pulpcore#2779
ipanova
added a commit
to ipanova/pulp_container
that referenced
this pull request
Jun 14, 2022
closes pulp#797 Required PR: pulp/pulpcore#2779
ipanova
added a commit
to ipanova/pulp_container
that referenced
this pull request
Jun 14, 2022
closes pulp#797 Required PR: pulp/pulpcore#2779
ipanova
added a commit
to ipanova/pulp_container
that referenced
this pull request
Jun 14, 2022
closes pulp#797 Required PR: pulp/pulpcore#2779
ipanova
added a commit
to ipanova/pulp_container
that referenced
this pull request
Jun 14, 2022
closes pulp#797 Required PR: pulp/pulpcore#2779 Required PR: pulp/pulpcore#2842
ipanova
added a commit
to ipanova/pulp_container
that referenced
this pull request
Jun 14, 2022
closes pulp#797 Required PR: pulp/pulpcore#2779
ipanova
force-pushed
the
upload-chunk
branch
2 times, most recently
from
1744096 to
d72d1ef
Compare
ipanova
added a commit
to ipanova/pulp_container
that referenced
this pull request
Jun 15, 2022
closes pulp#797 Required PR: pulp/pulpcore#2779
dkliban
approved these changes
Jun 21, 2022
fao89
approved these changes
Jun 21, 2022
bmbouter
reviewed
Jun 21, 2022
pulpcore/app/models/upload.py
Outdated
| if sha256: | ||
| current_sha256 = hashlib.sha256(chunk_read).hexdigest() | ||
| if sha256 != current_sha256: | ||
| raise serializers.ValidationError("Checksum does not match chunk upload.") |
There was a problem hiding this comment.
This I think is user facing so it should be wrapped in gettext
ipanova
added a commit
to ipanova/pulp_container
that referenced
this pull request
Jun 21, 2022
closes pulp#797 Required PR: pulp/pulpcore#2779
ipanova
added a commit
to ipanova/pulp_container
that referenced
this pull request
Jun 21, 2022
closes pulp#797 Required PR: pulp/pulpcore#2779
ipanova
added a commit
to ipanova/pulp_container
that referenced
this pull request
Jun 21, 2022
closes pulp#797 Required PR: pulp/pulpcore#2779
ipanova
added a commit
to ipanova/pulp_container
that referenced
this pull request
Jun 23, 2022
closes pulp#797 Required PR: pulp/pulpcore#2779
ipanova
added a commit
to ipanova/pulp_container
that referenced
this pull request
Jun 23, 2022
closes pulp#797 Required PR: pulp/pulpcore#2779
ipanova
added a commit
to ipanova/pulp_container
that referenced
this pull request
Jun 23, 2022
closes pulp#797 Required PR: pulp/pulpcore#2779
ipanova
added a commit
to ipanova/pulp_container
that referenced
this pull request
Jun 23, 2022
closes pulp#797 Required PR: pulp/pulpcore#2779
ipanova
added a commit
to ipanova/pulp_container
that referenced
this pull request
Jun 23, 2022
closes pulp#797 Required PR: pulp/pulpcore#2779
ipanova
added a commit
to ipanova/pulp_container
that referenced
this pull request
Jun 23, 2022
closes pulp#797 Required PR: pulp/pulpcore#2779
ipanova
added a commit
to ipanova/pulp_container
that referenced
this pull request
Jun 24, 2022
closes pulp#797 Required PR: pulp/pulpcore#2779
ipanova
added a commit
to pulp/pulp_container
that referenced
this pull request
Jun 24, 2022
closes #797 Required PR: pulp/pulpcore#2779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[noissue]
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/contributing/pull-request-walkthrough.html