Skip to content

Commit

Permalink
use StringSyntaxValue to retain pos info
Browse files Browse the repository at this point in the history
  • Loading branch information
aq17 committed Sep 27, 2023
1 parent a228d36 commit fd03986
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ast/expr.go
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ func parseShortOpen(node *syntax.ObjectNode, name *StringExpr, args Expr) (Expr,
return nil, syntax.Diagnostics{ExprError(args, fmt.Sprintf("the argument to fn::open::%s must be an object", provider), "")}
}

return OpenSyntax(node, name, inputs, String(provider), inputs), nil
return OpenSyntax(node, name, inputs, StringSyntaxValue(node, provider), inputs), nil

Check failure on line 620 in ast/expr.go

View workflow job for this annotation

GitHub Actions / lint / lint

cannot use node (variable of type *"github.com/pulumi/esc/syntax".ObjectNode) as *"github.com/pulumi/esc/syntax".StringNode value in argument to StringSyntaxValue) (typecheck)

Check failure on line 620 in ast/expr.go

View workflow job for this annotation

GitHub Actions / lint / lint

cannot use node (variable of type *"github.com/pulumi/esc/syntax".ObjectNode) as *"github.com/pulumi/esc/syntax".StringNode value in argument to StringSyntaxValue (typecheck)

Check failure on line 620 in ast/expr.go

View workflow job for this annotation

GitHub Actions / lint / lint

cannot use node (variable of type *"github.com/pulumi/esc/syntax".ObjectNode) as *"github.com/pulumi/esc/syntax".StringNode value in argument to StringSyntaxValue) (typecheck)

Check failure on line 620 in ast/expr.go

View workflow job for this annotation

GitHub Actions / test / Test (1.21.0, true)

cannot use node (variable of type *"github.com/pulumi/esc/syntax".ObjectNode) as *"github.com/pulumi/esc/syntax".StringNode value in argument to StringSyntaxValue
}

func parseJoin(node *syntax.ObjectNode, name *StringExpr, args Expr) (Expr, syntax.Diagnostics) {
Expand Down

0 comments on commit fd03986

Please sign in to comment.