cli: deeper support for show-secrets in env get #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #353. Also--the concrete changes to the shipping CLI are latent, and will not take effect until the ESC API is updated to respect the new query parameter. |
pgavlin
changed the title
pgavlin
force-pushed
the
pgavlin/esc-347-2
branch
from
4d17e37
to
ef9dc03
Compare
lblackstone
reviewed
Jul 17, 2024
lblackstone
approved these changes
Jul 17, 2024
cleverguy25
approved these changes
Jul 17, 2024
These changes plumb support for showing _all_ static secrets through `esc env get` (rather than only those secrets immediately present in the environment being read directly; i.e. including secrets from imported environments). Note that this support is latent, and the fix will not be user-visible until supporting code is deployed to the ESC API. Part of #347.
pgavlin
force-pushed
the
pgavlin/esc-347-2
branch
from
ef9dc03
to
d67f3d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes plumb support for showing all static secrets through
esc env get(rather than only those secrets immediately present inthe environment being read directly; i.e. including secrets from
imported environments).
Note that this support is latent, and the fix will not be user-visible
until supporting code is deployed to the ESC API.
Part of #347.