From fead6ab4b1c47f243751a511f31c88d6635e5488 Mon Sep 17 00:00:00 2001 From: Bryce Lampe Date: Tue, 17 Dec 2024 15:23:02 -0800 Subject: [PATCH] Remove `make upstream` from `preTest` (#166) After https://github.com/pulumi/ci-mgmt/pull/1151 our `make` targets should now all correctly call `make upstream` if they need it. This updates `.ci-mgmt.yaml` and re-runs `make ci-mgmt`. --- .ci-mgmt.yaml | 3 --- .github/workflows/license.yml | 3 ++- .github/workflows/lint.yml | 4 ++-- .github/workflows/main.yml | 3 +++ .github/workflows/prerelease.yml | 3 +++ .github/workflows/release.yml | 3 +++ .github/workflows/run-acceptance-tests.yml | 3 +++ .github/workflows/test.yml | 3 --- 8 files changed, 16 insertions(+), 9 deletions(-) diff --git a/.ci-mgmt.yaml b/.ci-mgmt.yaml index df22425..5fa4312 100644 --- a/.ci-mgmt.yaml +++ b/.ci-mgmt.yaml @@ -16,9 +16,6 @@ providerDefaultBranch: main actions: preTest: - - name: make upstream - run: | - make upstream - name: Run provider tests run: | cd provider && go test -v -json -count=1 -cover -timeout 2h -tags=${{ matrix.language }} -parallel 4 . 2>&1 | tee /tmp/gotest.log | gotestfmt diff --git a/.github/workflows/license.yml b/.github/workflows/license.yml index f1ef97e..16d825c 100644 --- a/.github/workflows/license.yml +++ b/.github/workflows/license.yml @@ -38,7 +38,8 @@ jobs: with: tools: go cache-go: false - - run: make upstream + - run: make prepare_local_workspace + continue-on-error: true - uses: pulumi/license-check-action@main with: module-path: provider diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 8efec38..0aa493b 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -44,9 +44,9 @@ jobs: continue-on-error: true # this fails if there are no go:embed directives run: | git grep -l 'go:embed' -- provider | xargs sed -i 's/go:embed/ goembed/g' - - name: prepare upstream + - name: prepare workspace continue-on-error: true - run: make upstream + run: make prepare_local_workspace - name: golangci-lint uses: golangci/golangci-lint-action@971e284b6050e8a5849b72094c50ab08da042db8 # v6 with: diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 4a76498..6249694 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -131,6 +131,9 @@ jobs: - prerequisites - build_provider - build_sdk + permissions: + contents: read + id-token: write secrets: inherit with: version: ${{ needs.prerequisites.outputs.version }} diff --git a/.github/workflows/prerelease.yml b/.github/workflows/prerelease.yml index 2dffdec..8736a9f 100644 --- a/.github/workflows/prerelease.yml +++ b/.github/workflows/prerelease.yml @@ -72,6 +72,9 @@ jobs: - prerequisites - build_provider - build_sdk + permissions: + contents: read + id-token: write secrets: inherit with: version: ${{ needs.prerequisites.outputs.version }} diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index ac7ff22..3720ee2 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -78,6 +78,9 @@ jobs: - prerequisites - build_provider - build_sdk + permissions: + contents: read + id-token: write secrets: inherit with: version: ${{ needs.prerequisites.outputs.version }} diff --git a/.github/workflows/run-acceptance-tests.yml b/.github/workflows/run-acceptance-tests.yml index dc2df3c..8d4402f 100644 --- a/.github/workflows/run-acceptance-tests.yml +++ b/.github/workflows/run-acceptance-tests.yml @@ -121,6 +121,9 @@ jobs: - prerequisites - build_provider - build_sdk + permissions: + contents: read + id-token: write secrets: inherit with: version: ${{ needs.prerequisites.outputs.version }} diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index e0734dd..dec8ae6 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -77,9 +77,6 @@ jobs: with: token: ${{ secrets.GITHUB_TOKEN }} version: v2.5.0 - - name: make upstream - run: | - make upstream - name: Run provider tests run: | cd provider && go test -v -json -count=1 -cover -timeout 2h -tags=${{ matrix.language }} -parallel 4 . 2>&1 | tee /tmp/gotest.log | gotestfmt