fix provision on dnf only platforms #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockylinux images recently dropped yum. other distros are likely to do the same.
2 tasks
bastelfreak
reviewed
May 12, 2024
| @@ -35,7 +31,8 @@ def install_ssh_components(distro, version, container) | |||
| 'do sleep 0.1 ; count=$((count+1)) ; done ; fi' | |||
| docker_exec(container, "bash -c '#{check_init_cmd}'") | |||
| end | |||
| docker_exec(container, 'yum install -y sudo openssh-server openssh-clients') | |||
| packager = (version.to_i > 8) ? 'dnf' : 'yum' | |||
There was a problem hiding this comment.
Isn't that off by one? EL8 already contains dnf?
There was a problem hiding this comment.
Could be, but I intentionally chose 9 as RedHat technically called it "yum 4" until EL 9.
TheMeier
approved these changes
May 12, 2024
jordanbreen28
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rockylinux images recently dropped yum. other distros are likely to do the same.
observed failures in litmusimage nightly smoke tests