(PUP-11896) Send auto-renew extension in CSR #9076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an auto-renew extension to the CSR when it is generated if the agent supports auto-renewal of certificates. Agents that either do not have the hostcert_renewal_interval setting or have it set to 0 do not support auto-renewal.
AriaXLi
force-pushed
the
PUP-11896/auto-renew_extension
branch
from
57a5c91
to
ae2cf20
Compare
joshcooper
reviewed
Jun 27, 2023
I'm not too sure...lemme ask Charlie about it just in case! Edit: He also doesn't really know why there's a jump between them and He did mention that |
joshcooper
approved these changes
Jun 28, 2023
AriaXLi
added a commit
to AriaXLi/puppet
that referenced
this pull request
Jun 29, 2023
This commit adds an auto-renew attribute to the CSR when it is generated if the agent supports auto-renewal of certificates. Agents that either do not have the hostcert_renewal_interval setting or have it set to 0 do not support auto-renewal. Originally, this was added as an auto-renew extension to the CSR (see puppetlabs#9076). However, in its default (FOSS) configuration, puppetserver rejects extensions so the auto-renew will be implemented as an attribute instead.
AriaXLi
added a commit
to AriaXLi/puppet
that referenced
this pull request
Jun 29, 2023
This commit adds an auto-renew attribute to the CSR when it is generated if the agent supports auto-renewal of certificates. Agents that either do not have the hostcert_renewal_interval setting or have it set to 0 do not support auto-renewal. Originally, this was added as an auto-renew extension to the CSR (see puppetlabs#9076). However, in its default (FOSS) configuration, puppetserver rejects extensions so the auto-renew will be implemented as an attribute instead.
AriaXLi
added a commit
to AriaXLi/puppet
that referenced
this pull request
Jun 29, 2023
This commit adds an auto-renew attribute to the CSR when it is generated if the agent supports auto-renewal of certificates. Agents that either do not have the hostcert_renewal_interval setting or have it set to 0 do not support auto-renewal. Originally, this was added as an auto-renew extension to the CSR (see puppetlabs#9076). However, in its default (FOSS) configuration, puppetserver rejects extensions so the auto-renew will be implemented as an attribute instead.
AriaXLi
added a commit
to AriaXLi/puppet
that referenced
this pull request
Jun 29, 2023
This commit adds an auto-renew attribute to the CSR when it is generated if the agent supports auto-renewal of certificates. Agents that either do not have the hostcert_renewal_interval setting or have it set to 0 do not support auto-renewal. Originally, this was added as an auto-renew extension to the CSR (see puppetlabs#9076). However, in its default (FOSS) configuration, puppetserver rejects extensions so the auto-renew will be implemented as an attribute instead.
AriaXLi
added a commit
to AriaXLi/puppet
that referenced
this pull request
Jun 29, 2023
This commit adds an auto-renew attribute to the CSR when it is generated if the agent supports auto-renewal of certificates. Agents that either do not have the hostcert_renewal_interval setting or have it set to 0 do not support auto-renewal. Originally, this was added as an auto-renew extension to the CSR (see puppetlabs#9076). However, in its default (FOSS) configuration, puppetserver rejects extensions so the auto-renew will be implemented as an attribute instead.
AriaXLi
added a commit
to AriaXLi/puppet
that referenced
this pull request
Jun 29, 2023
This commit adds an auto-renew attribute to the CSR when it is generated if the agent supports auto-renewal of certificates. Agents that either do not have the hostcert_renewal_interval setting or have it set to 0 do not support auto-renewal. Originally, this was added as an auto-renew extension to the CSR (see puppetlabs#9076). However, in its default (FOSS) configuration, puppetserver rejects extensions so the auto-renew will be implemented as an attribute instead.
joshcooper
pushed a commit
to AriaXLi/puppet
that referenced
this pull request
Jun 30, 2023
This commit adds an auto-renew attribute to the CSR when it is generated if the agent supports auto-renewal of certificates. Agents that either do not have the hostcert_renewal_interval setting or have it set to 0 do not support auto-renewal. Originally, this was added as an auto-renew extension to the CSR (see puppetlabs#9076). However, in its default (FOSS) configuration, puppetserver rejects extensions so the auto-renew will be implemented as an attribute instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an auto-renew extension to the CSR when it is generated if the agent supports auto-renewal of certificates. Agents that either do not have the
hostcert_renewal_intervalsetting or have it set to 0 do not support auto-renewal.