Add param package_manage #634
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Nov 27, 2025
manifests/init.pp
Outdated
| class haproxy ( | ||
| Variant[Enum['present', 'absent', 'purged', 'disabled', 'installed', 'latest'], String[1]] $package_ensure = 'present', | ||
| String $package_name = $haproxy::params::package_name, | ||
| Optional[String] $package_name = $haproxy::params::package_name, |
Collaborator
There was a problem hiding this comment.
I think this won't work. $haproxy::params::package_name will always provide a value. Even if you switch the datatype and pass in undef, puppet will get the default from the params.pp class.
Also I don't think setting the name to undef is the correct way to make the package installation optional. The better approach would be a new parameter, like $manage_package.
Author
There was a problem hiding this comment.
@bastelfreak - Thx for the review! I added $package_manage and changed PR summary & description. Can you pls. have another look?
chrisongthb
force-pushed
the
chrisongthb-package-name-optional
branch
from
e56da54 to
b0c524c
Compare
chrisongthb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently it is not possible to skip package installation.
Additional Context
This MR adds param
$package_manage, which lets the user decide on package mgmt.Related Issues (if any)
Currently none, but I can file an issue, if wanted...
Checklist
puppet apply)