Remove EOL CentOs-7 and CentOs-8 from metadata.json #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Jun 24, 2024
.github/workflows/ci.yml
Outdated
| uses: "puppetlabs/cat-github-actions/.github/workflows/module_acceptance.yml@main" | ||
| with: | ||
| flags: "--provision-service" | ||
| flags: "--provision-service --exclude-platforms '["CentOS-8"]'" |
Collaborator
There was a problem hiding this comment.
doesn't it make more sense to remove CentOS 8 from metadata.json?
Contributor
There was a problem hiding this comment.
Wanting to keep the supported version on forge. Centos 8 is no longer available from our VM provisioner, and planning to look in to using docker at a later stage
Collaborator
There was a problem hiding this comment.
CentOS 8 is EoL, Vox Pupuli is removing it from their modules. I think Puppet should do the same. If it's in the metadata.json, people will assume that it's working and tested. That's not the case anymore.
bastelfreak
reviewed
Jun 25, 2024
metadata.json
Outdated
| "operatingsystemrelease": [ | ||
| "7", | ||
| "8" | ||
| "7" |
Collaborator
There was a problem hiding this comment.
And CentOS 7 is EoL as well?
ragingra
approved these changes
Jun 25, 2024
Collaborator
|
@cathal41 can you maybe add a meaningful PR title before we merge it? |
cathal41
changed the title
cathal41
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removing CentOs-7 and CentOs-8 from metadata.json as the CI and Nightly tests are failing as CentOs-8 is no longer supported and CentOs-7 will reach EOL on the 30th of June 2024
Additional Context
CentOs-8 is no longer supported by PE and no longer available to be provisioned as a VM
Tests will continue to run on redhat-8, centOs-8 is a derivative of redhat-8
Checklist
Changes include test coverage?
Have you updated the documentation?