Skip to content

(PE-38653) Moving workflows install password to secrets #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2024
Merged

(PE-38653) Moving workflows install password to secrets #481

merged 1 commit into from
Aug 28, 2024

Conversation

@ragingra
Copy link
Contributor

@ragingra ragingra commented Aug 20, 2024 •
edited
Loading

Summary

Moving workflows install password to secrets

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.

Changes include test coverage?

  • Yes
  • Not needed

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

@ragingra ragingra marked this pull request as ready for review August 20, 2024 15:19
@ragingra ragingra requested review from a team as code owners August 20, 2024 15:19
timidri
timidri approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@timidri timidri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ragingra ragingra merged commit ab9db39 into main Aug 28, 2024
@ragingra ragingra deleted the PE-38653 branch August 28, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@timidri timidri timidri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ragingra @timidri @CoMfUcIoS