(maint) Fix issue #98, don't require pe_compiling_server_aio_build
#100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| true => pe_compiling_server_aio_build(), | ||
| default => undef, | ||
| if ($_is_pe && is_function_available('pe_compiling_server_aio_build')) { | ||
| $master_agent_version = pe_compiling_server_aio_build() |
There was a problem hiding this comment.
Can we add an else to explicitly set it to undef? We're going to get warnings all over the place otherwise.
There was a problem hiding this comment.
Ok. I also want to add a spec test.
|
Updated. |
|
👍 once specs pass. |
|
Specs are proving tricky. |
…io_build` Compilation should not require `pe_compiling_server_aio_build`. Skip calling it if not defined even if `is_pe` is true.
|
I think I got all the tests working. Got a little complicated. |
|
Heh, that did get a bit complicated. Still, the fundamental change make sense and the specs mostly cover its behavior so 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilation should not require
pe_compiling_server_aio_build. Skipcalling it if not defined even if
is_peis true.