(maint) Fix handling dev versions on Solaris 11 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Allow for normalizing package_version for the package provider via _package_version. | ||
| # This only needs to be passed through to install, as elsewhere we want to | ||
| # use the full version string for comparisons. | ||
| if !$_package_version { |
There was a problem hiding this comment.
Instead of relying on puppet's falsiness, maybe we should check $_package_version != undef?
Version numbers for development packages on Solaris 11 need to be munged, which happened for the file name. However Solaris 11 puppet-agent upgrades use the version number, which was not correctly munged. Fix that, and add testing for development version numbers.
MikaelSmith
force-pushed
the
fix-dev-versions
branch
from
54e266b to
50ec7f9
Compare
|
👍 Once travis passes. I ran this through a install.rb/agent_upgrade.rb beaker run, and followed up with acceptance/tests/ and it successfully upgraded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version numbers for development packages on Solaris 11 need to be
munged, which happened for the file name. However Solaris 11
puppet-agent upgrades use the version number, which was not correctly
munged. Fix that, and add testing for development version numbers.