(PE-11531) Fix upgrade issue with dev builds #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
highb
force-pushed
the
fix/master/pe-11531_fix_dev_build_upgrades
branch
from
cbe2af4 to
686ee8b
Compare
|
Failing specs. |
|
Gr, I thought I ran |
Prior to this commit the module would always upgrade with dev builds because they have a git SHA appended to the end, which `versioncmp` considers to be greater than the version reported by `aio_agent_version`, which lacks the extra git sha characters. This commit updates the update check to strip the git sha when comparing the `aio_agent_version` to the requested `packace_version`.
highb
force-pushed
the
fix/master/pe-11531_fix_dev_build_upgrades
branch
from
686ee8b to
1aa5e70
Compare
|
There, syntax passes locally. Sorry about that. |
|
Specs are getting complicated. Looks good though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the module would always upgrade with dev
builds because they have a git SHA appended to the end, which
versioncmpconsiders to be greater than the version reportedby
aio_agent_version, which lacks the extra git sha characters.This commit updates the update check to strip the git sha when
comparing the
aio_agent_versionto the requestedpackace_version.