(maint) Add puppet-lint workarounds for CI, use valid certnames #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our CI setup puts extra files in the project workspace, which puppet-lint then tries to lint. This fails for older versions of Puppet.
|
Something's still missing here to fix acceptance, working on it. |
Fix up SSL configuration for use with fixes in stomp 1.4.1. Without this the activemq-stomp connection will reject the connection.
MikaelSmith
force-pushed
the
fix-testing
branch
from
3337582 to
5138313
Compare
|
Fixed. /cc @highb |
|
👍 edit: will merge on the spec run finishes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(maint) Add puppet-lint workarounds for CI
Our CI setup puts extra files in the project workspace, which
puppet-lint then tries to lint. This fails for older versions of Puppet.
(maint) Fix test to use valid certnames
Fix up SSL configuration for use with fixes in stomp 1.4.1.
Without this the activemq-stomp connection will reject the connection.