(Modules-3970) Update puppet windows agent download url schema

[spacepants]

Hey there,

At some point the url schema for Windows agents in the repo was updated to https://downloads.puppetlabs.com/windows/puppet-agent-${version}-${arch}.msi, but the module is still looking for agent packages at https://downloads.puppetlabs.com/windows/puppet-agent-${arch}-${version}.msi

This updates the filename to point to the correct url.

Please let me know if this needs anything else.

Thanks! ❤️

[highb]

Good catch! Looking at https://downloads.puppetlabs.com/windows/ that matches up with this change, so I'm 👍 on this.

[highb]

Also, thanks for updating the specs! :)

[puppetcla]

Waiting for CLA signature by @spacepants

@spacepants - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

[puppetcla]

CLA signed by all contributors.

[MosesMendoza]

👍 on this PR

Unrelated to this PR it seems oddly incongruent that we name our "latest" MSI as <name>-<arch>-latest.msi, where "latest" is a standin for version making this string the equivalent of <name>-<arch>-<version>.msi, but all of our other versioned MSIs are <name>-<version>-<arch>.msi. I would have expected the latest MSI to be named <name>-latest-<arch>.msi.

[MosesMendoza]

This should have a ticket in the MODULES project - so I created https://tickets.puppetlabs.com/browse/MODULES-3970 to track it.

@spacepants would you mind updating your commit message title to have this ticket number in it,

ie from "Update puppet windows agent download url schema" to "(MODULES-3970) Update puppet windows agent download url schema" ?

[spacepants]

Sure thing. Updated both the commit message and the PR.

[glennsarti]

👍 for merge

[glennsarti]

Raised MODULES-3971 for adding an acceptance test for this at a later time.

[MosesMendoza]

Thanks @spacepants for this PR!