(MODULES-4092) Install solaris 10 package per-zone #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branan
force-pushed
the
bugs/master/modules-4092-solaris-zones-are-dumb
branch
from
3f6c061 to
dc88fa8
Compare
Solaris 10 packaging, when combined with zones, is super weird. The Puppet Enterprise frictionless install has historically made sure that the agent is installed per-zone. However, the `puppet_agent` module did not. This leads to conflicts when upgrading agents - once the Global zone is updated, trying to upgrade the other zones will fail, since the `puppet-agent` package is "already installed". This changes solaris 10 packaging to be per-zone, which matches how we have historically done that deployment.
branan
force-pushed
the
bugs/master/modules-4092-solaris-zones-are-dumb
branch
from
dc88fa8 to
37fbf3f
Compare
|
This seems sane. Whatever the frictionless installer does probably makes sense. I'm not aware of anyone who wants to install it for all zones, but that's the scenario where I could see this surprising someone. |
|
@highb have any concerns to add on this? Otherwise I think we can merge it? |
|
@MikaelSmith I'm not super familiar with Solaris zones, but making the module consistent with the frictionless installer seems like the right thing to do so 👍 from me. |
|
CLA signed by all contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solaris 10 packaging, when combined with zones, is super weird. The
Puppet Enterprise frictionless install has historically made sure that
the agent is installed per-zone. However, the
puppet_agentmoduledid not. This leads to conflicts when upgrading agents - once the
Global zone is updated, trying to upgrade the other zones will fail,
since the
puppet-agentpackage is "already installed".This changes solaris 10 packaging to be per-zone, which matches how we
have historically done that deployment.