Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-4424) Add skip_if_unavailable to yumrepo resource #205

Closed
wants to merge 1 commit into from

Conversation

walkamongus
Copy link

@walkamongus walkamongus commented Jan 13, 2017

The skip_if_unavailable yum option allows unrelated yum package
management to continue in the event that the agent repository
is unavailable for any reason. It is defaulted to 'absent', which means
the option is not set in the repository file.

The skip_if_unavailable yum option allows unrelated yum package
management to continue in the event that the agent repository
is unavailble for any reason. It is defaulted to 'absent', which means
the option is not set in the repository file.
@walkamongus
Copy link
Author

rebased onto latest

@walkamongus
Copy link
Author

@puppetcla
Copy link

Waiting for CLA signature by @walkamongus

@walkamongus - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

@@ -60,6 +60,7 @@
$install_dir = $::puppet_agent::params::install_dir,
$disable_proxy = false,
$install_options = $::puppet_agent::params::install_options,
$skip_if_unavailable = 'absent',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should have a yumrepo hash, that lets you override any particular parameters to setting up the repo... although that also sounds terrible.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this would be easy to do with the splat operator, but we'd have to wait until Puppet 3 support is dropped.

CLA signed.

@puppetcla
Copy link

CLA signed by all contributors.

@MikaelSmith MikaelSmith changed the title Add skip_if_unavailable to yumrepo resource (MODULES-4424) Add skip_if_unavailable to yumrepo resource Mar 10, 2017
@caseywilliams caseywilliams changed the base branch from master to 1.x June 14, 2018 21:47
@caseywilliams
Copy link
Contributor

Thanks, @walkamongus! This looks good. We'll rebase this change against the 1.x branch and merge.

@speedofdark
Copy link
Contributor

This is rebased against 1.x and replaced by #296.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants