(MODULES-7791) Remove deprecated source_permissions #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseywilliams
changed the title
caseywilliams
force-pushed
the
MODULES-7791/source-permissions
branch
from
6b2b8e9 to
1606dbf
Compare
|
CLA signed by all contributors. |
caseywilliams
force-pushed
the
MODULES-7791/source-permissions
branch
from
1606dbf to
aa17595
Compare
`source_permissions` is deprecated in puppet6; remove it and use the defaults to quiet warnings (The default permissions behavior in puppet 4, 5, and 6 is to use the puppet agent user and that user's default umask or DACL).
caseywilliams
force-pushed
the
MODULES-7791/source-permissions
branch
from
aa17595 to
700cd4d
Compare
|
Alternatively, would we want to just let the warnings happen for 1.x only? |
mcdonaldseanp
approved these changes
Oct 29, 2018
ScottGarman
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
source_permissionswas deprecated in PUP-5921.The suggested alternative to
source_permissions => usefor puppet 6 is to explicitly set user, group, and mode. I'm unsure how to best approach doing that for all the files in this part of the module, but curious to see whether the defaults are adequate (the default behavior is to use the puppet-agent user and their default umask/DACL)