(MODULES-8393) Add task required metadata, hide extra implementations #353
Conversation
|
Would be nice to see in the commit message that this is related to task metadata, since this module has been published to the forge for years. |
Adds task metadata required to publish to the Forge. Also declare input_method where it would use the default `both` and hide extra implementations for task runners that implement private tasks and task implementations.
MikaelSmith
force-pushed
the
MODULES-8393
branch
from
e285e53 to
f876868
Compare
MikaelSmith
changed the title
|
Done. Shipping to the forge with the current set of tasks would've failed because the forge requires that every task has a metadata file. |
|
I'd like someone who actually knows what task metadata looks like to approve this, but nothing jumps out to me as evil 👍 |
|
Looks like Ruby pre-2.3 may be borked. |
|
Should I drop |
|
We want this module to maintain support for Puppet 4, even in the master branch, so that lagging users can continue to use it to update. I believe the |
|
In other words, I have NFI what to do here. I'm fine merging this over the red, since it's just a metadata change. We'll have to work out the travis mess separately as part of readying this for a 2.0 release |
Ruby before 2.3 is no longer maintained, drop testing Ruby versions that are EOL. Also add testing with Puppet 6.
MikaelSmith
force-pushed
the
MODULES-8393
branch
from
623d7bd to
faf2dc9
Compare
|
Trying testing with Puppet 4 + Ruby 2.3. Not ideal, but better than red tests. |
|
Worked. I'll get someone from my team to review as well. |
|
CLA signed by all contributors. |
Adds task metadata required to publish to the Forge. Also declare
input_method where it would use the default
bothand hide extraimplementations for task runners that implement private tasks and task
implementations.