(maint) Allow install task to downlad macos 10.15 #471
Conversation
Add condintion to allow downloading puppet agent packages from 10.15 repo.
|
I just saw https://github.com/puppetlabs/ci-job-configs/commit/de5120505eef07097be8ba3c9beea07a4b789664#diff-420f83aded712be3e269ac56d953dc18R1325-R1326 was merged. Those acceptance tests have not yet triggered but when they do they will certainly fail without at least this commit. I suspect there will also be some other work making the tests not fail due to not having a puppet 5 version to upgrade from puppetlabs-puppet_agent/task_spec/spec/acceptance/init_spec.rb Lines 31 to 40 in e85f549 |
|
I wonder if it would be possible to make the module look where it expects the file to be and fail if it's not there, rather than continue to update it with new whitelists... |
|
CLA signed by all contributors. |
…10.15 Until we find a solution for puppetlabs/puppetlabs-puppet_agent#471 , adding macos catalina will not work for agent dependent acceptance tests. Also note we no longer build and test for 10.11.
…10.15 Until we find a solution for puppetlabs/puppetlabs-puppet_agent#471 , adding macos catalina will not work for agent dependent acceptance tests. Also note we no longer build and test for 10.11.
| @@ -176,6 +176,7 @@ if [ -f "$PT__installdir/facts/tasks/bash.sh" ]; then | |||
| "10.12") platform_version="10.12";; | |||
| "10.13") platform_version="10.13";; | |||
| "10.14") platform_version="10.14";; | |||
| "10.15") platform_version="10.15";; | |||
There was a problem hiding this comment.
Maybe check if major_version matches 10\.1[1-9] (to be on the safe side at least), then pass it on as is? We would get an uglier error when curl-ing the package but the file wouldn't need to be changed for each macOS release.
Add condintion to allow downloading puppet agent packages from 10.15 repo.