-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check that user is root only if installation is required #475
Conversation
I have checked |
As bolt only collects custom facts in apply_prep task, which first makes sure that the agent is installed, failing fast makes it impossible to gather custom facts when running as non-root even if the agent is already installed.
I have changed the commit message to make the CI pass. |
Waiting for CLA signature by @faucct @faucct - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/ Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html |
CLA signed by all contributors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I would defer to @puppetlabs/bolt team for final say.
WFM |
As
bolt
only collects custom facts inapply_prep
task, which first makes sure that the agent is installed, failing fast makes it impossible to gather custom facts when running as non-root even if the agent is already installed.