Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that user is root only if installation is required #475

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Check that user is root only if installation is required #475

merged 1 commit into from
Apr 1, 2020

Conversation

faucct
Copy link
Contributor

@faucct faucct commented Mar 11, 2020

As bolt only collects custom facts in apply_prep task, which first makes sure that the agent is installed, failing fast makes it impossible to gather custom facts when running as non-root even if the agent is already installed.

@faucct
Copy link
Contributor Author

faucct commented Mar 11, 2020

I have checked CONTRIBUTING.md and still don't understand what needs to be fixed for CI to pass. Should my commit message have a second line?

As bolt only collects custom facts in apply_prep task, which first makes sure that the agent is installed, failing fast makes it impossible to gather custom facts when running as non-root even if the agent is already installed.
@faucct
Copy link
Contributor Author

faucct commented Mar 11, 2020

I have changed the commit message to make the CI pass.
CONTRIBUTING.md could have some explanations for commit tags: I haven't found any tag that suits me and just took (maint) from recent commits without understanding what it means. Does it mean maintainer or maintenance?

@puppetcla
Copy link

Waiting for CLA signature by @faucct

@faucct - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

@puppetcla
Copy link

CLA signed by all contributors.

@gimmyxd gimmyxd requested a review from a team April 1, 2020 06:03
Copy link
Contributor

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I would defer to @puppetlabs/bolt team for final say.

@lucywyman lucywyman merged commit 7dd41d7 into puppetlabs:master Apr 1, 2020
@lucywyman
Copy link
Contributor

lucy ~/githubs/bolt (master) $ be bolt task run puppet_agent::install -t localhost
Started on localhost...
Finished on localhost:
  10:01:01 -0700 INFO: Version parameter not defined and agent detected. Nothing to do.
Successful on 1 target: localhost
Ran on 1 target in 0.08 sec
lucy ~/githubs/bolt (master) $ vi Puppetfile ^C
lucy ~/githubs/bolt (master) $ git checkout -- Puppetfile
lucy ~/githubs/bolt (master) $ bolt puppetfile install
Successfully synced modules from /home/lucy/githubs/bolt/Puppetfile to /home/lucy/githubs/bolt/modules
lucy ~/githubs/bolt (master) $ be bolt task run puppet_agent::install -t localhost
Started on localhost...
Failed on localhost:
  The task failed with exit code 1
  puppet_agent::install task must be run as root
Failed on 1 target: localhost
Ran on 1 target in 0.07 sec

WFM

@faucct faucct deleted the patch-1 branch May 5, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants