Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-10661) Add OS X 10.15 support #487

Merged
merged 1 commit into from
May 11, 2020

Conversation

GabrielNagy
Copy link
Contributor

Tested with PE by upgrading from agent version 6.13.0 to 6.15.0.

@GabrielNagy GabrielNagy requested a review from a team May 7, 2020 09:02
@puppetcla
Copy link

CLA signed by all contributors.

@ciprianbadescu ciprianbadescu requested a review from a team May 11, 2020 05:45
Rakefile Outdated
@@ -55,11 +55,12 @@ task(:commits) do
%x{git log --no-merges --pretty=%s #{commit_range}}.each_line do |commit_summary|
# This regex tests for the currently supported commit summary tokens.
# The exception tries to explain it in more full.
if /^\((maint|packaging|doc|docs|modules-\d+)\)|revert/i.match(commit_summary).nil?
if /^\((maint|packaging|doc|docs|(modules|pe)-\d+)\)|revert/i.match(commit_summary).nil?
Copy link
Contributor

@gimmyxd gimmyxd May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we decided to allow only MODULES for this repos to be easier to track them and manage release notes.
Upgrade support is also for FOSS but PE tickets are not public.

@GabrielNagy GabrielNagy force-pushed the PE-27501/add-osx-1015 branch from bc423f1 to 0c8964d Compare May 11, 2020 11:19
@GabrielNagy GabrielNagy changed the title (PE-27501) Add OS X 10.15 support (MODULES-10661) Add OS X 10.15 support May 11, 2020
@GabrielNagy GabrielNagy requested a review from gimmyxd May 11, 2020 11:19
@gimmyxd gimmyxd merged commit e7c1cd1 into puppetlabs:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants