(MODULES-10713) Fix agent upgrade on Solaris 11 #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to Solaris p5p limitations, we munge dev build versions by stripping all letters (i.e.: 5.5.20.102.g9e5216a6 turns to 5.5.20.102.952166). This causes `Gem::Version` to wrongly interpret the desired version on Solaris 11, making upgrades not idempotent. Use a regex instead of `Gem::Version` to make `package_version` more like the `aio_agent_version` fact. Move this logic from the provider to the Puppet manifests in order to be able to properly spec test this.
|
|
|
CLA signed by all contributors. |
gimmyxd
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to Solaris p5p limitations, we munge dev build versions by stripping all letters (i.e.: 5.5.20.102.g9e5216a6 turns to 5.5.20.102.952166).
This causes
Gem::Versionto wrongly interpret the desired version on Solaris 11, making upgrades not idempotent.Use a regex instead of
Gem::Versionto makepackage_versionmore like theaio_agent_versionfact. Move this logic from the provider to the Puppet manifests in order to be able to properly spec test this.