(MODULES-10806) Add Github Actions workflows #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luchihoratiu
force-pushed
the
MODULES-10806
branch
4 times, most recently
from
8115be5 to
eeb100a
Compare
|
CLA signed by all contributors. |
luchihoratiu
force-pushed
the
MODULES-10806
branch
6 times, most recently
from
d385725 to
46c2d61
Compare
luchihoratiu
force-pushed
the
MODULES-10806
branch
11 times, most recently
from
fede6ab to
8e35b3f
Compare
luchihoratiu
force-pushed
the
MODULES-10806
branch
4 times, most recently
from
4c04041 to
9d69a99
Compare
luchihoratiu
force-pushed
the
MODULES-10806
branch
19 times, most recently
from
1b86885 to
4efc4ad
Compare
GabrielNagy
reviewed
Sep 24, 2020
In preparation for the Puppet 7 release, the
`puppet-module-posix-dev-r2.7` and `puppet-module-posix-dev-r2.7` gems
had to be removed from `Gemfile` due to the following dependency error:
`puppet-module-posix-dev-r2.7` depends on
`puppet_litmus` which depends on
`bolt` which depends on
`puppet` which is locked to a version below 7
Also added the needed gems that were lost in the above removal process
with their respective uniformised version constraints.
Line endings mismatch (`\n` vs `\r\n`) in `*.erb` files caused test failures when asserting content of generated puppet catalog. This is solved by updating the `.gitatributes` file accordingly. Some paths got expanded to Windows paths (starting with drive letter such as `C:\`) and was causing test failures because of incorrect expectation.
This commit restricts Rubocop checks by disabling most cops and excluding nonessential paths so that it can be reenabled as a mandatory step in CI. Offences remaining after that were also solved. A future ticket should remove these restrictions and clean up the code accordingly.
luchihoratiu
force-pushed
the
MODULES-10806
branch
2 times, most recently
from
7777618 to
a3eb73a
Compare
Added GitHub Actions workflows for `Static Code Analysis`, `Unit Tests` and `Task Acceptance Tests` that run each time there is a new `pull request` or `git push`. `Unit tests` are also set to run every workday at `05:00:00 UTC`. The `.yaml` config file for `Travis` has been removed.
luchihoratiu
force-pushed
the
MODULES-10806
branch
from
a3eb73a to
c7e6b99
Compare
GabrielNagy
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added GitHub Actions workflows for
Static Code Analysis,Unit TestsandTask Acceptance Teststhat run each time there is a newpull requestorgit push.Unit testsare also set to run every workday at05:00:00 UTC.The
.yamlconfig file forTravishas been removed.Gemfile cleanup
In preparation for the Puppet 7 release, the
puppet-module-posix-dev-r2.7andpuppet-module-posix-dev-r2.7gems had to be removed fromGemfiledue to the following dependency error:..
puppet-module-posix-dev-r2.7depends on....
puppet_litmuswhich depends on......
boltwhich depends on........
puppetwhich is locked to a version below 7Also re-added only the needed gems that were lost in the above removal process (with the version constraints that were previously set here).
Github Actions run preview
Static Code Analysis: https://github.com/luchihoratiu/puppetlabs-puppet_agent/actions/runs/269047279Task Acceptance Tests: https://github.com/luchihoratiu/puppetlabs-puppet_agent/actions/runs/269047288Unit Tests with nightly Puppet gem: https://github.com/luchihoratiu/puppetlabs-puppet_agent/actions/runs/269047280Unit Tests with released Puppet gem: https://github.com/luchihoratiu/puppetlabs-puppet_agent/actions/runs/269047283For the daily run I've followed the official docs where it states:
So we should have our first preview run after merging the PR. I've set it to run
Monday-Fridayat 5am UTC but other preferences are welcomed!Badges preview
Added badges to
README.mdfor the above Github Actions workflows. They should look as below:+ daily one