Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-10780) PA 6 to PA 7 upgrade tests #510

Merged

Conversation

Dorin-Pleava
Copy link
Contributor

This PR tests the upgradability to puppet 7 using the
puppetlabs-puppet_agent module.

Currently it uses the puppet 7 nightly builds, as a puppet7 collection
does not exist.

@Dorin-Pleava Dorin-Pleava requested a review from a team September 14, 2020 11:19
@puppetcla
Copy link

CLA signed by all contributors.

@ciprianbadescu ciprianbadescu changed the base branch from master to main September 15, 2020 10:55
@ciprianbadescu
Copy link
Contributor

Could we keep one test and just set different *_source based on platform?

@gimmyxd gimmyxd requested a review from a team September 16, 2020 13:37
@Dorin-Pleava
Copy link
Contributor Author

Dorin-Pleava commented Sep 16, 2020

@ciprianbadescu I thought it could work, but that manifest is generated on the master node, and it only knows about the OS of the master. I am trying to create a manifest that has this logic, but don't think the syntax allows for something like this.

$source = case $facts['os']['name'] {
    /^(Debian|Ubuntu)$/: { "apt_source => 'http://nightlies.puppet.com/apt'" }
    /^(Redhat|CentOS|Fedora)$/: { "yum_source => 'http://nightlies.puppet.com/yum'" }
}

class { puppet_agent:
  package_version => '7.0.0.224.gaf2034af',
  $source,
  collection      => 'puppet7-nightly'
}

@Dorin-Pleava Dorin-Pleava force-pushed the MODULES-10780/upgrade_puppet_7_tests branch 3 times, most recently from 0ace6b3 to b0b8606 Compare September 17, 2020 10:38
@Dorin-Pleava Dorin-Pleava force-pushed the MODULES-10780/upgrade_puppet_7_tests branch from b0b8606 to 3b98985 Compare September 17, 2020 12:41
@GabrielNagy GabrielNagy requested a review from a team September 18, 2020 07:14
agents_only.each do |agent|
start_puppet_service_and_wait_for_puppet_run(agent)
wait_for_installation_pid(agent)
assert_agent_version_on(agent, latest_version.scan(/\d*\.\d*\.\d*\.\d*/).first)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first digit should be 7 i guess, to make sure that the upgrade succeed.

This PR tests the upgradability to puppet 7 using the
puppetlabs-puppet_agent module.

Currently it uses the puppet 7 nightly builds, as a puppet7 collection
does not exist.
@Dorin-Pleava Dorin-Pleava force-pushed the MODULES-10780/upgrade_puppet_7_tests branch from 3b98985 to 8bf6d8f Compare September 21, 2020 09:08
@GabrielNagy GabrielNagy merged commit 7b57b66 into puppetlabs:main Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants