Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support download with perl file::fetch #697

Merged
merged 1 commit into from
Feb 12, 2024
Merged

support download with perl file::fetch #697

merged 1 commit into from
Feb 12, 2024

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented Feb 10, 2024

minimal OS installs without wget or curl may not have perl LWP::Simple either, but perl File::Fetch is often available.

@h0tw1r3 h0tw1r3 added the enhancement New feature or request label Feb 10, 2024
@h0tw1r3 h0tw1r3 requested review from bastelfreak and a team as code owners February 10, 2024 07:15
kenyon
kenyon reviewed Feb 10, 2024
View reviewed changes
tasks/install_shell.sh Show resolved Hide resolved
tasks/install_shell.sh Show resolved Hide resolved
mhashizume
mhashizume approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@mhashizume mhashizume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @h0tw1r3 !

@mhashizume mhashizume merged commit 87bebd3 into puppetlabs:main Feb 12, 2024
17 checks passed
@h0tw1r3 h0tw1r3 deleted the perl-file-fetch branch February 12, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenyon kenyon kenyon left review comments

@mhashizume mhashizume mhashizume approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@h0tw1r3 @kenyon @bastelfreak @mhashizume